Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto set batch no on serial no selection #20757

Merged
merged 9 commits into from Mar 26, 2020

Conversation

nextchamp-saqib
Copy link
Member

If an item has serial nos as well as batch nos then on selection of serial no, the batch no it belongs will be auto fetched.

Copy link
Member

@nabinhait nabinhait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "Selected Batch Numbers" should be "Selected Serial Numbers" if item has both serial and batch.
  • Make warehouse mandatory to auto fetch serial nos
  • Dialog does not appear if "Set Source Warehouse" selected in DN and then added item. Same issue with "Add serial no" once serial nos set using dialog

@nabinhait nabinhait merged commit faea854 into frappe:develop Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants