Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect status creating PR from PO after creating PI #25109

Merged
merged 4 commits into from Apr 3, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Mar 31, 2021

Steps to reproduce:

  1. Create a PO
  2. Create PI from the PO with 100% qty.
  3. Create PR from PO with 100% qty.
  4. Refresh the PR page 1-2 times. (important)
  5. Check "More info" section of PR. It will have "Draft" status but 100% billed.

Unexpected behaviour:

  1. New PR has 100% billed percentage. (gets copied from PO it was created with, which is incorrect in case of partial / mix PRs)
  2. Because of 100% status icon shows Completed however doc.status is still in draft.

ToDo:

  • Add tests for reproducing both issues
  • Fix updation of status if 100% completed
  • Do not copy percentage billed
  • Write patch for existing records

Closes #23489
Related issues: ISS-20-21-10948, ISS-20-21-10868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purchase Receipt Status field value getting wrong in database
2 participants