Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: backport ruff linting/formatting #40943

Merged
merged 6 commits into from
Apr 12, 2024
Merged

chore: backport ruff linting/formatting #40943

merged 6 commits into from
Apr 12, 2024

Conversation

akhilnarang
Copy link
Member

Backport of #40681, #40719

@barredterra @akhilnarang
chore: switch to ruff for python formatting/linting
c28d19c 
(cherry picked from commit 8afb779)
(cherry picked from commit 9eeedd8)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
akhilnarang and others added 4 commits April 10, 2024 17:13
@akhilnarang
refactor(treewide): formatting and ruff fixes, + manually enabled F401
4d34b1e 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@akhilnarang
fix(treewide): manual ruff fixes
b087fb3 
(cherry picked from commit f63396e)
(cherry picked from commit 7828eee)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@akhilnarang
fix: exclude some query builder lines from ruff rules
2425119 
`== None` and `== True` are intentional here

(cherry picked from commit ac69513)
(cherry picked from commit 41d7c03)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@ruthra-kumar @akhilnarang
fix: use 'eq' and isnull() on qb conditions
b4ed2d2 
(cherry picked from commit eee86d2)
(cherry picked from commit 2268995)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@akhilnarang
chore: gitignore ruff format
cf3c26d 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@akhilnarang akhilnarang merged commit f0ecc62 into frappe:version-14-hotfix Apr 12, 2024
7 of 10 checks passed
@akhilnarang akhilnarang deleted the v14-ruff branch April 12, 2024 05:31
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.67.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush Awaiting requested review from ankush ankush is a code owner

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
accounts assets buying CRM ecommerce projects projects module related issue / PR released selling stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akhilnarang @frappe-pr-bot @barredterra @ruthra-kumar