From 508bff1b08bcf2331c3613057f347b66a28990f3 Mon Sep 17 00:00:00 2001 From: Kanchan Chauhan Date: Mon, 30 Jan 2017 17:39:37 +0530 Subject: [PATCH] Salary Structure Employee custom field can be used in Formula and Condition --- erpnext/hr/doctype/salary_slip/salary_slip.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/erpnext/hr/doctype/salary_slip/salary_slip.py b/erpnext/hr/doctype/salary_slip/salary_slip.py index de205e3bdd28..5ff1248717d8 100644 --- a/erpnext/hr/doctype/salary_slip/salary_slip.py +++ b/erpnext/hr/doctype/salary_slip/salary_slip.py @@ -89,8 +89,8 @@ def eval_condition_and_formula(self, d, data): frappe.throw(_("Name error: {0}".format(err))) except SyntaxError as err: frappe.throw(_("Syntax error in formula or condition: {0}".format(err))) - except: - frappe.throw(_("Error in formula or condition")) + except Exception, e: + frappe.throw(_("Error in formula or condition: {0}".format(e))) raise def get_data_for_eval(self): @@ -99,7 +99,7 @@ def get_data_for_eval(self): for d in self._salary_structure_doc.employees: if d.employee == self.employee: - data.base, data.variable = d.base, d.variable + data.update(frappe.get_doc("Salary Structure Employee", {"employee": self.employee}).as_dict()) data.update(frappe.get_doc("Employee", self.employee).as_dict()) data.update(self.as_dict()) @@ -108,7 +108,6 @@ def get_data_for_eval(self): salary_components = frappe.get_all("Salary Component", fields=["salary_component_abbr"]) for salary_component in salary_components: data[salary_component.salary_component_abbr] = 0 - return data