From 9dfcbd1c80f2dfce5f5a493ed8fa72e1799bb32e Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 9 May 2024 12:10:21 +0530 Subject: [PATCH] fix: Increase folder link field size (#26381) * fix: increase folder length to 255 File `name` is 255 because it's bootstrapped using mariadb.sql, so users can create 255 char long folders but can't store anything in it. * fix(UX): slightly better character len message Highlight field by making it bold. (cherry picked from commit 53517630aec90d931ed004a04750c20d420670c5) # Conflicts: # frappe/core/doctype/file/file.json # frappe/model/base_document.py --- frappe/core/doctype/file/file.json | 5 +++++ frappe/model/base_document.py | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/frappe/core/doctype/file/file.json b/frappe/core/doctype/file/file.json index 11f80183b76..95a3fe6924b 100644 --- a/frappe/core/doctype/file/file.json +++ b/frappe/core/doctype/file/file.json @@ -106,6 +106,7 @@ "fieldtype": "Link", "hidden": 1, "label": "Folder", + "length": 255, "options": "File", "read_only": 1 }, @@ -188,7 +189,11 @@ "icon": "fa fa-file", "idx": 1, "links": [], +<<<<<<< HEAD "modified": "2023-07-26 14:03:49.456951", +======= + "modified": "2024-05-09 11:46:42.917146", +>>>>>>> 53517630ae (fix: Increase folder link field size (#26381)) "modified_by": "Administrator", "module": "Core", "name": "File", diff --git a/frappe/model/base_document.py b/frappe/model/base_document.py index a00e825aa4c..ffbd38cb997 100644 --- a/frappe/model/base_document.py +++ b/frappe/model/base_document.py @@ -969,7 +969,11 @@ def throw_length_exceeded_error(self, df, max_length, value): frappe.throw( _("{0}: '{1}' ({3}) will get truncated, as max characters allowed is {2}").format( +<<<<<<< HEAD reference, _(df.label), max_length, value +======= + reference, frappe.bold(_(df.label, context=df.parent)), max_length, value +>>>>>>> 53517630ae (fix: Increase folder link field size (#26381)) ), frappe.CharacterLengthExceededError, title=_("Value too big"),