From ab2b8dff7cc5aa88d8a1a6bedbf567d7ffe79058 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Tue, 1 Nov 2022 17:44:44 +0530 Subject: [PATCH] fix: webform validation script not working (cherry picked from commit cc20037af99632159805694e2256ff3c0f5427a5) --- frappe/public/js/frappe/web_form/web_form.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/web_form/web_form.js b/frappe/public/js/frappe/web_form/web_form.js index b8f7c327f6b..52d417f0256 100644 --- a/frappe/public/js/frappe/web_form/web_form.js +++ b/frappe/public/js/frappe/web_form/web_form.js @@ -347,11 +347,13 @@ export default class WebForm extends frappe.ui.FieldGroup { save() { let is_new = this.is_new; - if (this.validate && !this.validate()) { - frappe.throw( + let valid = this.validate && this.validate(); + if (!valid && valid !== undefined) { + frappe.msgprint( __("Couldn't save, please check the data you have entered"), __("Validation Error") ); + return false; } // validation hack: get_values will check for missing data