Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace deleted when app is uninstalled #18024

Closed
ankush opened this issue Sep 2, 2022 · 0 comments · Fixed by #18025
Closed

workspace deleted when app is uninstalled #18024

ankush opened this issue Sep 2, 2022 · 0 comments · Fixed by #18025
Assignees
Labels

Comments

@ankush
Copy link
Member

ankush commented Sep 2, 2022

Hi ankush,

Since latest version all workspaces are deleted (json file on repository) when uninstalling the custom app
Shouldn't we also check if we are not in "uninstall" mode in "disable_saving_as_public" method?

def disable_saving_as_public():
return (
frappe.flags.in_install
or frappe.flags.in_patch
or frappe.flags.in_test
or frappe.flags.in_fixtures
or frappe.flags.in_migrate
or frappe.flags.in_uninstall
)

Best regards,

originally posted by @mterceno on bde4e44

@ankush ankush added the bug label Sep 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants