Skip to content

fix(frappe client): validate http method for frappe.client api #11228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 14, 2020

Conversation

saurabh6790
Copy link
Member

ISS-20-21-03151

@saurabh6790 saurabh6790 requested review from a team and Thunderbottom and removed request for a team August 10, 2020 11:04
@saurabh6790 saurabh6790 added critical dont-merge test-required Python test is required for the proposed feature/fix. labels Aug 10, 2020
@surajshetty3416 surajshetty3416 added add-docs New feature should be have an entry in documentation to increase the discoverability travis-failing labels Aug 11, 2020
@saurabh6790 saurabh6790 force-pushed the validate-http-methods branch from 4b918ea to ec7a8b7 Compare August 11, 2020 10:19
@stale
Copy link

stale bot commented Aug 22, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@surajshetty3416
Copy link
Member

@saurabh6790 Any update on this?

@saurabh6790 saurabh6790 force-pushed the validate-http-methods branch from effd464 to ddc7de4 Compare September 7, 2020 08:12
@saurabh6790
Copy link
Member Author

@surajshetty3416 pushed test cases to test valid and invalid behaviour

@saurabh6790 saurabh6790 removed add-docs New feature should be have an entry in documentation to increase the discoverability test-required Python test is required for the proposed feature/fix. labels Sep 7, 2020
@saurabh6790
Copy link
Member Author

Broken test cases are not related to these fixes

@saurabh6790 saurabh6790 force-pushed the validate-http-methods branch 2 times, most recently from c8d0e43 to f6c7054 Compare September 8, 2020 11:01
@saurabh6790 saurabh6790 changed the title fix: validate http method for frappe.client api fix(frappe client): validate http method for frappe.client api Sep 10, 2020
@surajshetty3416 surajshetty3416 merged commit a0086db into frappe:develop Sep 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants