New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: No redis dependency during tests and install #11880
fix: No redis dependency during tests and install #11880
Conversation
Adding a user during after_install hook caused error during install of an app
@stephenBDT Do you have traceback of any sort for this ?? The |
Yes, but without the |
Here is the StackTrace: @hrwX
|
@hrwX please merge this, it is very easy to see, that the call to It was there for Without this flag, |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
…endency-during-setup-1
This is just a quick little fix, so that when one adds a user in the after_install hook, the app doesn't become uninstallable anymore.
When one added a new user in the after_install hook, the app became uninstallable, as it tried to execute a background job.
This fails because redis is not available during installation of an app.
Now this is fixed by telling that background job, that it should execute immediately during tests and installs
None