fix: Translation related issues #11932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make description and HTML options with line breaks translatable
make onboard step and shortcut format translatable
make html options translatable
fix translation issue
fix translation issue
fix translation issue
fix Chinese language key
fix Chinese language key
fix translation
fix translation issue
fix from different path goes to list view, the sidebar menu appear multiple times issue
ghost
removed their request for review
add translate
This comment has been minimized.
This comment has been minimized.
revert back
|
@surajshetty3416 @gavindsouza |
surajshetty3416
requested changes
Jan 20, 2021
surajshetty3416
changed the title
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
|
@surajshetty3416 |
@szufisher all checks need to have a green tick before we can merge the PR. |
fix the pr semantic issue
|
@surajshetty3416 |
|
@szufisher we are squashing commits in this PR since none of the commit messages (except one) is following conventional commit message guidelines. |
surajshetty3416
approved these changes
Feb 1, 2021
ankush
reviewed
May 20, 2022
| @@ -128,6 +128,7 @@ frappe.ui.keys.AltShortcutGroup = class AltShortcutGroup { | |||
| return !this.is_taken(letter) && is_valid_char; | |||
| }); | |||
| if (!shortcut_letter) { | |||
| $text_el.attr('data-label', text_content); | |||
There was a problem hiding this comment.
@szufisher @surajshetty3416 any idea why this was added here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly added the missing translation call __(), and fixed some translation related bugs.
related discussion thread
https://discuss.erpnext.com/t/html-field-as-formatted-description-is-not-translatable/67806
https://discuss.erpnext.com/t/question-why-line-break-return-has-been-replaced-by-empty-string-in-js-translate-function-which-caused-some-description-not-translatable/67803
issues
#11856