From 3305d38c1ee503097c72c8dc220892d587a4080a Mon Sep 17 00:00:00 2001
From: "Abdallah A. Zaqout" <26047413+zaqoutabed@users.noreply.github.com>
Date: Sun, 11 Dec 2022 18:12:14 +0300
Subject: [PATCH 1/3] feat: allow user to pick all columns

---
 frappe/public/js/frappe/form/print_utils.js | 24 +++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/frappe/public/js/frappe/form/print_utils.js b/frappe/public/js/frappe/form/print_utils.js
index fcafb4b4daa..fa47d8608b0 100644
--- a/frappe/public/js/frappe/form/print_utils.js
+++ b/frappe/public/js/frappe/form/print_utils.js
@@ -38,7 +38,31 @@ frappe.ui.get_print_settings = function (pdf, callback, letter_head, pick_column
 				label: __("Pick Columns"),
 				fieldtype: "Check",
 				fieldname: "pick_columns",
+				onchange: function () {
+                    if (cur_dialog) {
+                        $(cur_dialog.body).find(':checkbox[data-fieldname="pick_all"]')
+                            .prop("checked", 1)
+                            .trigger('click');
+                    }
+
+                }
 			},
+			{
+                label: __("Pick All Columns"),
+                fieldtype: "Check",
+                fieldname: "pick_all",
+                depends_on: "pick_columns",
+                onchange: function () {
+                    if (cur_dialog) {
+                        const checked = this.value == 1 ? false : true;
+                        $(cur_dialog.body).find('[data-fieldtype="MultiCheck"]').map((index, element) => {
+                            $(element).find(`:checkbox`)
+                                .prop("checked", this.value == 1 ? false : true)
+                                .trigger('click');
+                        });
+                    }
+                }
+            },
 			{
 				label: __("Select Columns"),
 				fieldtype: "MultiCheck",

From e31c1ef8750f49da4c2d1a04998abd36fdeb24c3 Mon Sep 17 00:00:00 2001
From: "Abdallah A. Zaqout" <26047413+zaqoutabed@users.noreply.github.com>
Date: Mon, 12 Dec 2022 20:13:02 +0300
Subject: [PATCH 2/3] extra check field

---
 frappe/public/js/frappe/form/print_utils.js | 27 ++-------------------
 1 file changed, 2 insertions(+), 25 deletions(-)

diff --git a/frappe/public/js/frappe/form/print_utils.js b/frappe/public/js/frappe/form/print_utils.js
index fa47d8608b0..9693dbbf053 100644
--- a/frappe/public/js/frappe/form/print_utils.js
+++ b/frappe/public/js/frappe/form/print_utils.js
@@ -37,38 +37,15 @@ frappe.ui.get_print_settings = function (pdf, callback, letter_head, pick_column
 			{
 				label: __("Pick Columns"),
 				fieldtype: "Check",
-				fieldname: "pick_columns",
-				onchange: function () {
-                    if (cur_dialog) {
-                        $(cur_dialog.body).find(':checkbox[data-fieldname="pick_all"]')
-                            .prop("checked", 1)
-                            .trigger('click');
-                    }
-
-                }
+				fieldname: "pick_columns"
 			},
-			{
-                label: __("Pick All Columns"),
-                fieldtype: "Check",
-                fieldname: "pick_all",
-                depends_on: "pick_columns",
-                onchange: function () {
-                    if (cur_dialog) {
-                        const checked = this.value == 1 ? false : true;
-                        $(cur_dialog.body).find('[data-fieldtype="MultiCheck"]').map((index, element) => {
-                            $(element).find(`:checkbox`)
-                                .prop("checked", this.value == 1 ? false : true)
-                                .trigger('click');
-                        });
-                    }
-                }
-            },
 			{
 				label: __("Select Columns"),
 				fieldtype: "MultiCheck",
 				fieldname: "columns",
 				depends_on: "pick_columns",
 				columns: 2,
+				select_all: true,
 				options: pick_columns.map((df) => ({
 					label: __(df.label),
 					value: df.fieldname,

From a006bb54e26ef1544aef73dc8d4c8a662f4b3856 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
Date: Tue, 13 Dec 2022 13:34:43 +0530
Subject: [PATCH 3/3] chore: linter fix

---
 frappe/public/js/frappe/form/print_utils.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frappe/public/js/frappe/form/print_utils.js b/frappe/public/js/frappe/form/print_utils.js
index 9693dbbf053..1fd0942186f 100644
--- a/frappe/public/js/frappe/form/print_utils.js
+++ b/frappe/public/js/frappe/form/print_utils.js
@@ -37,7 +37,7 @@ frappe.ui.get_print_settings = function (pdf, callback, letter_head, pick_column
 			{
 				label: __("Pick Columns"),
 				fieldtype: "Check",
-				fieldname: "pick_columns"
+				fieldname: "pick_columns",
 			},
 			{
 				label: __("Select Columns"),