fix(Email Search): cast iterator to list #21669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barredterra
requested review from
a team and
phot0n
and removed request for
a team
|
The sempgrep failure is unrelated to this fix. Removing the |
|
🎉 This PR is included in version 13.58.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search functionality in the email modal uses the whitelisted method
get_contact_list. Currently, inversion-13, the search does not work, giving empty search results for valid queries.Problem
The
filterfunction is used to get rid of anyNonevalues in the result. However, it returns a python iterator while the frontend expects a list of dictionaries.Solution
Cast the iterator to a list. This is already implemented in
developandversion-14.