Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to extract or not images from Custom HTML #3845

Closed
wants to merge 1 commit into from

Conversation

@fproldan
Copy link

fproldan commented Aug 2, 2017

Added option in custom html of print format to allow define if the images should be extracted.
The follow image shows a use case:

captura de pantalla 2017-08-02 a la s 11 15 48

Post in discuss for more details

This PR is an alternative solution of #3844

@mbauskar

This comment has been minimized.

Copy link
Contributor

mbauskar commented Aug 3, 2017

@fproldan,

Thanks for the Pull Request, Can you please check the Travis logs and fix the tests cases? If you are facing the test_customize_form.js test please rebase, Closing the PR for now, but you reopen it

@mbauskar mbauskar closed this Aug 3, 2017
@fproldan

This comment has been minimized.

Copy link
Author

fproldan commented Aug 8, 2017

@mbauskar I'm facing the test_customize_forms.js, I've updated my fork, how can I reopen this PR?
Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.