Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup stages #4618

Merged
merged 6 commits into from Dec 21, 2017
Merged

Setup stages #4618

merged 6 commits into from Dec 21, 2017

Conversation

@pratu16x7
Copy link
Contributor

pratu16x7 commented Dec 14, 2017

Will affect: frappe/erpnext#12000

__setup_progress

Failed State: specific error messages
__setup_fail

Completed State
setup_complete

  • Staged tasks executed in order, doesn’t execute further steps on error.
  • Not any particular fix, but good for diagnosis and maintenance.
  • Works for all apps.

New hook: setup_wizard_stages that returns a stages list, backward compatible to setup_wizard_complete hooks

Deferred global search sync.

@pratu16x7 pratu16x7 mentioned this pull request Dec 14, 2017
1 of 1 task complete
@pratu16x7 pratu16x7 force-pushed the pratu16x7:setup-refactor branch 3 times, most recently from c89260b to a80447a Dec 14, 2017
@rmehta

This comment has been minimized.

Copy link
Member

rmehta commented Dec 18, 2017

rebase?

@pratu16x7 pratu16x7 force-pushed the pratu16x7:setup-refactor branch from a80447a to 9b6f674 Dec 20, 2017
@nabinhait nabinhait merged commit d5ad0ff into frappe:develop Dec 21, 2017
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
security/snyk No new issues
Details
security/snyk - requirements.txt No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.