Postgres support for Frappe #5919

rmehta · 2018-08-04T08:30:18Z

To create a new site (with Postgres DB)

bench new-site <site-name> --db-type postgres

realvinay · 2018-08-06T11:35:00Z

@riteshshrv , please test this branch with our app/datasets and provide feedback.

riteshshrv · 2018-08-07T09:41:20Z

@surajshetty3416 https://github.com/frappe/frappe/blob/develop/frappe/database.py#L56
is there a specific reason not to inherit base class from object ?
Ref: https://stackoverflow.com/questions/4015417/python-class-inherits-object

I faced a issue while trying to init a new site using postgres, here's the traceback

  File "/usr/lib64/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/ritesh/Projects-Active/frappe-crux/apps/frappe/frappe/utils/bench_helper.py", line 97, in <module>
    main()
  File "/home/ritesh/Projects-Active/frappe-crux/apps/frappe/frappe/utils/bench_helper.py", line 18, in main
    click.Group(commands=commands)(prog_name='bench')
  File "/home/ritesh/Projects-Active/frappe-crux/env/lib/python2.7/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/ritesh/Projects-Active/frappe-crux/env/lib/python2.7/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/ritesh/Projects-Active/frappe-crux/env/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/ritesh/Projects-Active/frappe-crux/env/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/ritesh/Projects-Active/frappe-crux/env/lib/python2.7/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/ritesh/Projects-Active/frappe-crux/env/lib/python2.7/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/ritesh/Projects-Active/frappe-crux/apps/frappe/frappe/commands/site.py", line 33, in new_site
    db_type = db_type)
  File "/home/ritesh/Projects-Active/frappe-crux/apps/frappe/frappe/commands/site.py", line 66, in _new_site
    source_sql=source_sql,force=force, reinstall=reinstall, db_type=db_type)
  File "/home/ritesh/Projects-Active/frappe-crux/apps/frappe/frappe/installer.py", line 38, in install_db
    setup_database(force, verbose)
  File "/home/ritesh/Projects-Active/frappe-crux/apps/frappe/frappe/database/__init__.py", line 13, in setup_database
    return frappe.database.postgres.setup_db.setup_database(force, verbose)
  File "/home/ritesh/Projects-Active/frappe-crux/apps/frappe/frappe/database/postgres/setup_db.py", line 6, in setup_database
    root_conn.commit()
  File "/home/ritesh/Projects-Active/frappe-crux/apps/frappe/frappe/database/database.py", line 757, in commit
    self.sql("commit")
  File "/home/ritesh/Projects-Active/frappe-crux/apps/frappe/frappe/database/postgres/database.py", line 101, in sql
    return super(PostgresDatabase, self).sql(query, *args, **kwargs)
TypeError: super() argument 1 must be type, not classobj

adding object inheritance fixed it

surajshetty3416 · 2018-08-07T14:13:00Z

@riteshshrv The link you sent describes that it makes no difference to inherit from an object if you are using Python 3.
And since I was on Python 3 while development I never came across that issue.

Anyways, I'll extend it from an object as we need to support Python 2 as well.

Thanks for reporting.

riteshshrv · 2018-08-13T09:31:46Z

@surajshetty3416 there seems to be some problem with "sessions";
i do not have complete information as there's no relevant traceback in both browser and terminal console but just letting you know in case if it might be helpful.
this does not happen if you login in Incognito!

creating a new doctype failed, is it just me or this part is still under development?

surajshetty3416 · 2018-08-14T05:47:11Z

@riteshshrv I have fixed Doctype Sessions not found issue... please pull the latest code and try again.

Also, will fix that new Doctype creation issue and let you know..

riteshshrv · 2018-08-14T08:33:21Z

@surajshetty3416 i'm using python2.7 env and login is now broken in both regular and incognito

  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/app.py", line 53, in application
    init_request(request)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/app.py", line 115, in init_request
    frappe.local.http_request = frappe.auth.HTTPRequest()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/auth.py", line 51, in __init__
    frappe.local.login_manager = LoginManager()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/auth.py", line 105, in __init__
    if self.login()==False: return
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/auth.py", line 126, in login
    self.authenticate(user=user, pwd=pwd)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/auth.py", line 209, in authenticate
    self.check_if_enabled(user)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/auth.py", line 214, in check_if_enabled
    doc = frappe.get_doc("System Settings")
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/__init__.py", line 709, in get_doc
    doc = frappe.model.document.get_doc(*args, **kwargs)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 69, in get_doc
    return controller(*args, **kwargs)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 104, in __init__
    self.load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 127, in load_from_db
    if not getattr(self, "_metaclass", False) and self.meta.issingle:
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 62, in meta
    self._meta = frappe.get_meta(self.doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/__init__.py", line 734, in get_meta
    return frappe.model.meta.get_meta(doctype, cached=cached)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 37, in get_meta
    meta = Meta(doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 84, in __init__
    super(Meta, self).__init__("DocType", doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 104, in __init__
    self.load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 89, in load_from_db
    super(Meta, self).load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 149, in load_from_db
    table_fields = self.meta.get_table_fields()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 62, in meta
    self._meta = frappe.get_meta(self.doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/__init__.py", line 734, in get_meta
    return frappe.model.meta.get_meta(doctype, cached=cached)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 35, in get_meta
    meta = Meta(meta)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 77, in __init__
    super(Meta, self).__init__(doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 113, in __init__
    super(Document, self).__init__(kwargs)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 53, in __init__
    self.update(d)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 76, in update
    self.set(key, value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 123, in set
    self.extend(key, value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 160, in extend
    self.append(key, v)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 137, in append
    value = self._init_child(value, key)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 175, in _init_child
    value = get_controller(value["doctype"])(value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 114, in __init__
    self.init_valid_columns()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 240, in init_valid_columns
    for key in self.get_valid_columns():
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 250, in get_valid_columns
    valid = self.meta.get_valid_columns()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 62, in meta
    self._meta = frappe.get_meta(self.doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/__init__.py", line 734, in get_meta
    return frappe.model.meta.get_meta(doctype, cached=cached)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 37, in get_meta
    meta = Meta(doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 84, in __init__
    super(Meta, self).__init__("DocType", doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 104, in __init__
    self.load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 89, in load_from_db
    super(Meta, self).load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 149, in load_from_db
    table_fields = self.meta.get_table_fields()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 62, in meta
    self._meta = frappe.get_meta(self.doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/__init__.py", line 734, in get_meta
    return frappe.model.meta.get_meta(doctype, cached=cached)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 35, in get_meta
    meta = Meta(meta)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 77, in __init__
    super(Meta, self).__init__(doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 113, in __init__
    super(Document, self).__init__(kwargs)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 53, in __init__
    self.update(d)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 76, in update
    self.set(key, value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 123, in set
    self.extend(key, value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 160, in extend
    self.append(key, v)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 137, in append
    value = self._init_child(value, key)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 175, in _init_child
    value = get_controller(value["doctype"])(value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 114, in __init__
    self.init_valid_columns()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 240, in init_valid_columns
    for key in self.get_valid_columns():
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 250, in get_valid_columns
    valid = self.meta.get_valid_columns()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 62, in meta
    self._meta = frappe.get_meta(self.doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/__init__.py", line 734, in get_meta
    return frappe.model.meta.get_meta(doctype, cached=cached)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 37, in get_meta
    meta = Meta(doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 84, in __init__
    super(Meta, self).__init__("DocType", doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 104, in __init__
    self.load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 89, in load_from_db
    super(Meta, self).load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 149, in load_from_db
    table_fields = self.meta.get_table_fields()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 62, in meta
    self._meta = frappe.get_meta(self.doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/__init__.py", line 734, in get_meta
    return frappe.model.meta.get_meta(doctype, cached=cached)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 35, in get_meta
    meta = Meta(meta)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 77, in __init__
    super(Meta, self).__init__(doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 113, in __init__
    super(Document, self).__init__(kwargs)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 53, in __init__
    self.update(d)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 76, in update
    self.set(key, value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 123, in set
    self.extend(key, value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 160, in extend
    self.append(key, v)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 137, in append
    value = self._init_child(value, key)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 175, in _init_child
    value = get_controller(value["doctype"])(value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 114, in __init__
    self.init_valid_columns()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 240, in init_valid_columns
    for key in self.get_valid_columns():
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 250, in get_valid_columns
    valid = self.meta.get_valid_columns()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 62, in meta
    self._meta = frappe.get_meta(self.doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/__init__.py", line 734, in get_meta
    return frappe.model.meta.get_meta(doctype, cached=cached)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 37, in get_meta
    meta = Meta(doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 84, in __init__
    super(Meta, self).__init__("DocType", doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 104, in __init__
    self.load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 89, in load_from_db
    super(Meta, self).load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 149, in load_from_db
    table_fields = self.meta.get_table_fields()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 62, in meta
    self._meta = frappe.get_meta(self.doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/__init__.py", line 734, in get_meta
    return frappe.model.meta.get_meta(doctype, cached=cached)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 35, in get_meta
    meta = Meta(meta)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 77, in __init__
    super(Meta, self).__init__(doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 113, in __init__
    super(Document, self).__init__(kwargs)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 53, in __init__
    self.update(d)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 76, in update
    self.set(key, value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 123, in set
    self.extend(key, value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 160, in extend
    self.append(key, v)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 137, in append
    value = self._init_child(value, key)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 175, in _init_child
    value = get_controller(value["doctype"])(value)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 114, in __init__
    self.init_valid_columns()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 240, in init_valid_columns
    for key in self.get_valid_columns():
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 250, in get_valid_columns
    valid = self.meta.get_valid_columns()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/base_document.py", line 62, in meta
    self._meta = frappe.get_meta(self.doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/__init__.py", line 734, in get_meta
    return frappe.model.meta.get_meta(doctype, cached=cached)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 37, in get_meta
    meta = Meta(doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 84, in __init__
    super(Meta, self).__init__("DocType", doctype)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 104, in __init__
    self.load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/meta.py", line 89, in load_from_db
    super(Meta, self).load_from_db()
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/model/document.py", line 139, in load_from_db
    d = frappe.db.get_value(self.doctype, self.name, "*", as_dict=1)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/database/database.py", line 441, in get_value
    order_by, cache=cache)
  File "/home/ritesh/Projects-Active/frappe-psql/apps/frappe/frappe/database/database.py", line 490, in get_values
    elif (not ignore) and frappe.db.is_table_missing(e):
  File "/home/ritesh/Projects-Active/frappe-psql/env/lib/python2.7/site-packages/werkzeug/local.py", line 347, in __getattr__
    return getattr(self._get_current_object(), name)
  File "/home/ritesh/Projects-Active/frappe-psql/env/lib/python2.7/site-packages/werkzeug/local.py", line 308, in _get_current_object
    return getattr(self.__local, self.__name__)
RuntimeError: maximum recursion depth exceeded

surajshetty3416 · 2018-08-16T05:44:54Z

@riteshshrv can you please recheck... I am not getting that error..

Also, If it turns out to be a python 2 specific issue, can you please add commit with a fix.

- Separate frameworkSQL, database, schema, setup_db file for mariaDB and postgres - WIP

Add other required refactoring

- Remove db_schema.py file

coveralls · 2018-09-10T07:04:05Z

Coverage increased (+0.06%) to 54.953% when pulling 31df1cb on surajshetty3416:pg-poc into 1a2993e on frappe:develop.

coveralls · 2018-09-10T07:04:05Z

Coverage increased (+0.06%) to 54.953% when pulling 31df1cb on surajshetty3416:pg-poc into 1a2993e on frappe:develop.

- move install and tests commands to separate files - Use matrix to build combination of python version and db type

- fixes - "echo won't expand escape sequences." warning

rmehta changed the title ~~Pg poc~~ [wip] [proposal] Postgres support in Frappe Aug 4, 2018

surajshetty3416 force-pushed the pg-poc branch from 56ab92b to b2a1e55 Compare August 5, 2018 16:18

surajshetty3416 force-pushed the pg-poc branch 3 times, most recently from 77945cd to bf3a6de Compare August 13, 2018 07:16

surajshetty3416 force-pushed the pg-poc branch from 97e0d55 to e09882d Compare August 16, 2018 03:54

surajshetty3416 force-pushed the pg-poc branch 2 times, most recently from 2043a59 to 40bf322 Compare August 16, 2018 05:48

rmehta and others added 15 commits August 16, 2018 18:22

[start] postgres

f4a96e9

[wip] started refactoring db_schema

fa020f6

Add psycopg2 to requirements.txt

5cdd4a2

Add support for Postgres SQL

7e85a8b

- Separate frameworkSQL, database, schema, setup_db file for mariaDB and postgres - WIP

Remove quotes from sql to make it compatible with postgres as well

f9024dc

Moved some code from db_schema to database.py

49e963c

Move code from db_schema to schema.py

74d4083

Add other required refactoring

Add schema chages

5a96d76

Remove redundant code in file

26846f6

Add invalid column name exception class to exceptions.py

e7566bf

Add back tick in query wherever needed and replace ifnull with coalesce

83fe8d8

Update get_column_description code in database.py file

8c5440e

Remove a print statement

711f278

Add keys to get on_duplicate query

f389d6c

Add bactick wherever necessary

6db4fba

- Remove db_schema.py file

surajshetty3416 changed the title ~~Postgres support in Frappe~~ Postgres support for Frappe Sep 11, 2018

surajshetty3416 added 24 commits September 17, 2018 10:54

Merge branch 'develop' of https://github.com/frappe/frappe into pg-poc

6292aab

Add python 2.7 test

2f92b68

Move python versions in travis.yml

5181ec5

Add python versions to jobs

38ee93f

Overwrite python version inheritance for postgres in travis.yml

88ba17c

Add quotes around python version in .travis.yml

5ab39b8

Add quotes around the name of the job

9b5d0c0

Try a travis fix

5122762

Try .travis.yml fix

a4c5553

Import missing subprocess

31e362c

Refactor travis.yml

913b731

Refactor travis.yml

65517f5

- move install and tests commands to separate files - Use matrix to build combination of python version and db type

Make install.sh and run-tests.sh executable

bc40ef0

Add sudo required to travis.yml to allow sudo cmmands in shell files

dacaafe

Load nvm

7ae1e50

Remove verbose flag from scripts

6250957

Remove command-trace-print flag

34c5c24

Change to build dir in before script

5dd31f6

Add absolute path for scripts

6e9fdb4

Fix tests

2f01e8b

Fix typo

13cefbe

Fix codacy

cfb3369

- fixes - "echo won't expand escape sequences." warning

Append (_) underscore instead of 'd' for db_name

97e0aa0

Remove printf and use mysql execute flag

8c8e11b

surajshetty3416 merged commit 2e6a202 into frappe:develop Sep 21, 2018

surajshetty3416 mentioned this pull request Aug 12, 2019

chore: Remove unwanted/unused db_schema.py #8165

Merged

github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Postgres support for Frappe #5919

Postgres support for Frappe #5919

rmehta commented Aug 4, 2018 •

edited by surajshetty3416

realvinay commented Aug 6, 2018

riteshshrv commented Aug 7, 2018 •

edited

surajshetty3416 commented Aug 7, 2018 •

edited

riteshshrv commented Aug 13, 2018

surajshetty3416 commented Aug 14, 2018 •

edited

riteshshrv commented Aug 14, 2018

surajshetty3416 commented Aug 16, 2018

coveralls commented Sep 10, 2018

coveralls commented Sep 10, 2018

Postgres support for Frappe #5919

Postgres support for Frappe #5919

Conversation

rmehta commented Aug 4, 2018 • edited by surajshetty3416

realvinay commented Aug 6, 2018

riteshshrv commented Aug 7, 2018 • edited

surajshetty3416 commented Aug 7, 2018 • edited

riteshshrv commented Aug 13, 2018

surajshetty3416 commented Aug 14, 2018 • edited

riteshshrv commented Aug 14, 2018

surajshetty3416 commented Aug 16, 2018

coveralls commented Sep 10, 2018

coveralls commented Sep 10, 2018

rmehta commented Aug 4, 2018 •

edited by surajshetty3416

riteshshrv commented Aug 7, 2018 •

edited

surajshetty3416 commented Aug 7, 2018 •

edited

surajshetty3416 commented Aug 14, 2018 •

edited