New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore_page): Modules and Module Detail views #6821

Merged
merged 29 commits into from Feb 7, 2019

Conversation

Projects
None yet
8 participants
@pratu16x7
Copy link
Contributor

pratu16x7 commented Jan 24, 2019

A more organised Modules Page, building from the current Explore page.

Kept Badges as they were because they serve the function of 'click to show open count'.

ERPNext PR: frappe/erpnext#16480

erpnext develop_8000_desk
erpnext develop_8000_desk 2
erpnext develop_8000_desk 1

@parsimonyERP

This comment has been minimized.

Copy link

parsimonyERP commented Jan 24, 2019

👍 👍 👍

@pratu16x7

This comment has been minimized.

Copy link
Contributor Author

pratu16x7 commented Jan 25, 2019

We @frappe propose to make this the desk view by default, replacing the desk and desktop icons. This will solve the hierarchy structure for the app and make it easier for users to find their way about.

While ideally, it will solve many navigational issues, what does everyone who uses desktop icons think? IMHO it will require plenty of change in habit/muscle memory for them. The current desk also serves as a frequently-used-items-that-I-don't-have-to-navigate-to-or-type-in-awesome-bar view for them.

Initially, to make the transition smooth, we could have both views to exist and simply add an option to select what view the user wants to be the default desk. The default view will be the new modules view, but they can switch it back to the old one. We will deprecate the desk at a point soon enough, though.

@vjFaLk

This comment has been minimized.

Copy link
Contributor

vjFaLk commented Jan 25, 2019

I think people like having shortcuts for the things they do often, so let's not take away that entirely. I think removing the desk is a step backwards in UX.

Also, opening ERPNext and instantly looking at all of the modules will be quite intimidating! Users are not like Developers, we're used to being hit by tons of info, Users would rather have as few options as possible.

@parsimonyERP

This comment has been minimized.

Copy link

parsimonyERP commented Jan 25, 2019

I like this new format very much. (In fact last week I designed a similar one for our users.) The current version does have a slight familiarity for users because they look like the apps on their phones, but the "buttons are very similar, the colors don't have any intuitive meaning and the graphics are duplicated. In my version, I did some grouping around larger "buttons" and added text links to let the user dive deeper and quicker.
I endorse a change in this direction.

@chdecultot

This comment has been minimized.

Copy link
Contributor

chdecultot commented Jan 25, 2019

Hi @pratu16x7 , I also fully agree with the replacement of the Desk. While some users may like it, I receive a lot of negative feedback about it.
I think it may just be a little outdated...

The new module view is great! Thanks for your work!

In terms of UX, the challenge is to be able to make a nice and easy navigation system. Maybe the common used links or users selected links could be available from the module view in replacement of the Desk (in a side panel or floating button ?). @vjFaLk is right about having to provide just the right amount of data to the end user... making complex things simple is very difficult !

Show resolved Hide resolved frappe/core/page/desktop/desktop.js Outdated
Show resolved Hide resolved frappe/public/js/frappe/views/components/Desktop.vue Outdated
Show resolved Hide resolved frappe/public/js/frappe/views/pageview.js Outdated

@pratu16x7 pratu16x7 force-pushed the pratu16x7:explore-2.0 branch from 9df4e4c to c8bc68e Feb 7, 2019

@rmehta

rmehta approved these changes Feb 7, 2019

@rmehta rmehta merged commit 056daa8 into frappe:develop Feb 7, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (frappe) No new issues
Details
security/snyk - requirements.txt (frappe) No manifest changes detected
@ishanloya

This comment has been minimized.

Copy link
Contributor

ishanloya commented Feb 11, 2019

Module icons don't seem to be showing like they do in the screenshot

@sagarvora

This comment has been minimized.

Copy link
Contributor

sagarvora commented Feb 11, 2019

How about we add a section called Shortcuts in the modules page at the top?
If a user is using something frequently and isn't acquainted with awesome bar (there's many of these), one click is better than two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment