Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Raw Printing): Adding Support for qz-tray #7088

Merged
merged 9 commits into from Apr 19, 2019

Conversation

Projects
None yet
4 participants
@karthikeyan5
Copy link
Collaborator

commented Mar 18, 2019

Screenshots:

  • printing by raw commands for the first time
    raw-printing-from-print-view

  • creating a new Raw Commands print format
    raw-command-print-format

Documentation PR: frappe/erpnext_com#308

@rmehta
Copy link
Member

left a comment

Also add code comments and docs

Show resolved Hide resolved frappe/public/js/frappe/form/print.js Outdated
Show resolved Hide resolved frappe/public/build.json Outdated
@karthikeyan5

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 4, 2019

todo:

  • add a print setting called "Enable Raw Printing"
  • Add more comments in the code
  • add documentation about instaling qz-tray right in the UI
  • add documentation about raw commands in the new print format UI
  • make a Documentation PR for "Raw Printing" Feature

@karthikeyan5 karthikeyan5 force-pushed the karthikeyan5:raw-printing branch 2 times, most recently from 2361208 to 32ba0c1 Apr 10, 2019

@karthikeyan5 karthikeyan5 force-pushed the karthikeyan5:raw-printing branch from 32ba0c1 to 49c7583 Apr 15, 2019

@karthikeyan5 karthikeyan5 requested a review from rmehta Apr 15, 2019

@rmehta

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@karthikeyan5 lets use "Printer Settings" instead of "Raw Print Settings"

the term "Raw Print" is not very user friendly

Show resolved Hide resolved frappe/public/build.json Outdated
Show resolved Hide resolved frappe/public/js/frappe/form/print.js Outdated
Show resolved Hide resolved frappe/public/js/frappe/form/print.js Outdated

@karthikeyan5 karthikeyan5 force-pushed the karthikeyan5:raw-printing branch from 49c7583 to b737d0b Apr 16, 2019

@karthikeyan5 karthikeyan5 force-pushed the karthikeyan5:raw-printing branch from b737d0b to 5997907 Apr 16, 2019

karthikeyan5 added some commits Mar 18, 2019

fix(Raw Printing): fixes as per PR review
> fixing confusing naming in the UI and calling it "Raw Print"
> used import for sha256 library
> changed the Print Preview message for raw print
> same possible codacy fixes
fix(Raw Printing): fixes as per PR review 2
> qz-tray.js and sha256.min.js are loaded only on demand
> renamed 'raw print settings' button to 'Printer Settings'
> removed commented code
> fixed spelling mistakes

@karthikeyan5 karthikeyan5 force-pushed the karthikeyan5:raw-printing branch from 5997907 to 2ec7c51 Apr 16, 2019

@karthikeyan5 karthikeyan5 requested a review from rmehta Apr 16, 2019

@rmehta rmehta merged commit 7817b4e into frappe:develop Apr 19, 2019

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
security/snyk - package.json (frappe) No new issues
Details
security/snyk - requirements.txt (frappe) No manifest changes detected

@karthikeyan5 karthikeyan5 deleted the karthikeyan5:raw-printing branch Apr 19, 2019

@TurkerTunali

This comment has been minimized.

Copy link

commented May 17, 2019

@karthikeyan5 lets use "Printer Settings" instead of "Raw Print Settings"

the term "Raw Print" is not very user friendly

"Direct Print" may be more suitable. I've looked other ERP systems but they just name it as "Print". There are no more options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.