Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Prepared Report): System Setting to automatically delete old prepared reports #9751

Merged
merged 13 commits into from Aug 18, 2020

Conversation

prssanna
Copy link
Contributor

@prssanna prssanna commented Mar 20, 2020

  • System Setting to automatically delete old prepared reports:

Screenshot 2020-07-29 at 5 41 35 PM

  • Warning dialog if there are already Prepared Reports with the same filters in the queue:

Screenshot 2020-07-29 at 5 11 56 PM

  • Disable button till report is generated to prevent rage clicking:

prepared report button

@prssanna prssanna changed the title fix(Prepared Report): Disable generate report button till report is generated [WIP] fix(Prepared Report): Disable generate report button till report is generated Mar 20, 2020
@stale
Copy link

stale bot commented Mar 30, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Mar 30, 2020
@stale stale bot closed this Apr 2, 2020
@prssanna prssanna reopened this Jul 29, 2020
@stale stale bot removed the inactive label Jul 29, 2020
@prssanna prssanna requested review from surajshetty3416 and a team as code owners July 29, 2020 12:10
@ghost ghost removed their request for review July 29, 2020 12:10
@prssanna prssanna changed the title [WIP] fix(Prepared Report): Disable generate report button till report is generated feat(Prepared Report): System Setting to automatically delete old prepared reports Jul 29, 2020
@stale
Copy link

stale bot commented Aug 8, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@mergify mergify bot merged commit 7f14c29 into frappe:develop Aug 18, 2020
@prssanna
Copy link
Contributor Author

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2020

Command backport version-12-hotfix: failure

No backport have been created

  • Backport to branch version-12-hotfix failed

Cherry-pick of 212ee26 has failed:

On branch mergify/bp/version-12-hotfix/pr-9751
Your branch is ahead of 'origin/version-12-hotfix' by 2 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 212ee269d6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   frappe/core/doctype/system_settings/system_settings.js

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   frappe/core/doctype/system_settings/system_settings.json

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants