Skip to content

fix(server-plan-fixtures): Sync server plans from prod#6640

Merged
regdocs merged 3 commits into
developfrom
fix-server-plans-with-mismatched-instance-type
Jun 9, 2026
Merged

fix(server-plan-fixtures): Sync server plans from prod#6640
regdocs merged 3 commits into
developfrom
fix-server-plans-with-mismatched-instance-type

Conversation

@regdocs

@regdocs regdocs commented Jun 8, 2026

Copy link
Copy Markdown
Member
  • Rectify mismatching instance types
  • Add two additional plans present in db but absent in fixture

- Rectify mismatching instance types
- Add two additional plans present in db but absent in fixture
@regdocs regdocs requested a review from balamurali27 June 8, 2026 09:03
@regdocs regdocs requested a review from ssiyad as a code owner June 8, 2026 09:03
@regdocs regdocs changed the title fix(plan_instance_type): Sync server plans from prod fix(plan-instance-type): Sync server plans from prod Jun 8, 2026
@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR syncs server_plan.json fixtures with production by correcting mismatched instance_type, title, platform, and memory/vcpu fields across several existing plans, and adds two new plans that were present in the database but missing from the fixture.

  • Corrects 7 existing plans where instance_type (and in some cases platform, memory, vcpu) did not match the plan's name key (e.g. c6g.large-af-south-1-db was pointing at m6g.large, m8g.2xlarge was pointing at c8g.xlarge).
  • Adds c8i.4xlarge-ap-south-1-app and c7g.large-ap-south-1b-db; the first new entry has a trailing comma in its roles array that renders the entire file invalid JSON.

Confidence Score: 2/5

The fixture file is currently invalid JSON due to a trailing comma, which will cause the fixture import to fail entirely — none of the corrections or new plans will be applied until the comma is removed.

The trailing comma at line 44459 breaks strict JSON parsing; bench reload-doc / fixture loading will raise a json.JSONDecodeError before any of the corrected or new plan records are written to the database.

press/fixtures/server_plan.json — trailing comma in the roles array of the c8i.4xlarge-ap-south-1-app entry.

Important Files Changed

Filename Overview
press/fixtures/server_plan.json Fixes mismatched instance_type/title/platform fields across 7 plans and adds 2 new plans; new c8i.4xlarge-ap-south-1-app entry contains a trailing comma in its roles array that makes the entire file invalid JSON.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
press/fixtures/server_plan.json:44456-44462
Trailing comma inside the `roles` array makes this file invalid JSON. Python's `json.load` (used by Frappe's fixture loader) strictly rejects trailing commas, so running `bench reload-doc` or any fixture import will raise a `json.JSONDecodeError` and abort, leaving the two new plans unloaded.

```suggestion
		"roles": [
			{
				"role": "Press User"
			}
		],
		"server_type": "Server",
		"title": "c8i.4xlarge",
```

Reviews (3): Last reviewed commit: "fix(server-plan-fixtures): Update roles ..." | Re-trigger Greptile

Comment thread press/fixtures/server_plan.json Outdated
@codecov-commenter

codecov-commenter commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.17%. Comparing base (0427ed9) to head (b5ecd80).
⚠️ Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6640      +/-   ##
===========================================
- Coverage    50.19%   50.17%   -0.02%     
===========================================
  Files          990      990              
  Lines        83000    83021      +21     
  Branches       523      523              
===========================================
- Hits         41660    41659       -1     
- Misses       41308    41330      +22     
  Partials        32       32              
Flag Coverage Δ
dashboard 62.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Want your agent to iterate on Greptile's feedback? Try greploops.

@regdocs regdocs merged commit 8103afa into develop Jun 9, 2026
4 checks passed
@regdocs regdocs deleted the fix-server-plans-with-mismatched-instance-type branch June 9, 2026 11:56
@regdocs regdocs changed the title fix(plan-instance-type): Sync server plans from prod fix(server-plan-fixtures): Sync server plans from prod Jun 9, 2026
Comment on lines +44456 to +44462
"roles": [
{
"role": "Press User"
},
],
"server_type": "Server",
"title": "c8i.4xlarge",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Trailing comma inside the roles array makes this file invalid JSON. Python's json.load (used by Frappe's fixture loader) strictly rejects trailing commas, so running bench reload-doc or any fixture import will raise a json.JSONDecodeError and abort, leaving the two new plans unloaded.

Suggested change
"roles": [
{
"role": "Press User"
},
],
"server_type": "Server",
"title": "c8i.4xlarge",
"roles": [
{
"role": "Press User"
}
],
"server_type": "Server",
"title": "c8i.4xlarge",
Prompt To Fix With AI
This is a comment left during a code review.
Path: press/fixtures/server_plan.json
Line: 44456-44462

Comment:
Trailing comma inside the `roles` array makes this file invalid JSON. Python's `json.load` (used by Frappe's fixture loader) strictly rejects trailing commas, so running `bench reload-doc` or any fixture import will raise a `json.JSONDecodeError` and abort, leaving the two new plans unloaded.

```suggestion
		"roles": [
			{
				"role": "Press User"
			}
		],
		"server_type": "Server",
		"title": "c8i.4xlarge",
```

How can I resolve this? If you propose a fix, please make it concise.

@regdocs

regdocs commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio backport release/2026-W24

@mergify

mergify Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

backport release/2026-W24

✅ Backports have been created

Details

regdocs added a commit that referenced this pull request Jun 9, 2026
fix(server-plan-fixtures): Sync server plans from prod (backport #6640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants