fix(server-plan-fixtures): Sync server plans from prod#6640
Conversation
regdocs
commented
Jun 8, 2026
- Rectify mismatching instance types
- Add two additional plans present in db but absent in fixture
- Rectify mismatching instance types - Add two additional plans present in db but absent in fixture
|
| Filename | Overview |
|---|---|
| press/fixtures/server_plan.json | Fixes mismatched instance_type/title/platform fields across 7 plans and adds 2 new plans; new c8i.4xlarge-ap-south-1-app entry contains a trailing comma in its roles array that makes the entire file invalid JSON. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
press/fixtures/server_plan.json:44456-44462
Trailing comma inside the `roles` array makes this file invalid JSON. Python's `json.load` (used by Frappe's fixture loader) strictly rejects trailing commas, so running `bench reload-doc` or any fixture import will raise a `json.JSONDecodeError` and abort, leaving the two new plans unloaded.
```suggestion
"roles": [
{
"role": "Press User"
}
],
"server_type": "Server",
"title": "c8i.4xlarge",
```
Reviews (3): Last reviewed commit: "fix(server-plan-fixtures): Update roles ..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6640 +/- ##
===========================================
- Coverage 50.19% 50.17% -0.02%
===========================================
Files 990 990
Lines 83000 83021 +21
Branches 523 523
===========================================
- Hits 41660 41659 -1
- Misses 41308 41330 +22
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
| "roles": [ | ||
| { | ||
| "role": "Press User" | ||
| }, | ||
| ], | ||
| "server_type": "Server", | ||
| "title": "c8i.4xlarge", |
There was a problem hiding this comment.
Trailing comma inside the
roles array makes this file invalid JSON. Python's json.load (used by Frappe's fixture loader) strictly rejects trailing commas, so running bench reload-doc or any fixture import will raise a json.JSONDecodeError and abort, leaving the two new plans unloaded.
| "roles": [ | |
| { | |
| "role": "Press User" | |
| }, | |
| ], | |
| "server_type": "Server", | |
| "title": "c8i.4xlarge", | |
| "roles": [ | |
| { | |
| "role": "Press User" | |
| } | |
| ], | |
| "server_type": "Server", | |
| "title": "c8i.4xlarge", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: press/fixtures/server_plan.json
Line: 44456-44462
Comment:
Trailing comma inside the `roles` array makes this file invalid JSON. Python's `json.load` (used by Frappe's fixture loader) strictly rejects trailing commas, so running `bench reload-doc` or any fixture import will raise a `json.JSONDecodeError` and abort, leaving the two new plans unloaded.
```suggestion
"roles": [
{
"role": "Press User"
}
],
"server_type": "Server",
"title": "c8i.4xlarge",
```
How can I resolve this? If you propose a fix, please make it concise.|
@Mergifyio backport release/2026-W24 |
✅ Backports have been createdDetails
|
fix(server-plan-fixtures): Sync server plans from prod (backport #6640)