Use unminified file in "main" in bower.json #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[As per Bower's commands](https://github.com/bower/bower.json-spec#main). Side note: I've been thinking of including `textAngular-sanitize.js` but it's not really mandatory. Is there any way to actually use `angular-sanitize.js` and override the usage of it? That way we can include `angular-sanitize.js` to the dependency and add the overrides to the main (or add them to `textAngular.js`).
Didn't notice textAngular.min.js was a minified version of the combined two.
|
Thanks for pointing this out. I'll merge it as is for now. As for the On the other hand, I'm awaiting this: angular/angular.js#5900 so hopefully we can do away with textAngular-sanitize altogether. When I get time I may attempt to help out on that, but it is slated for the next milestone so one can hope! |
SimeonC
pushed a commit
that referenced
this pull request
Sep 4, 2014
fix(bower) Use unminified file in "main" in bower.json as per bower spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Bower's commands.
Side note: I've been thinking of including
textAngular-sanitize.jsbut it's not really mandatory. Is there any way to actually useangular-sanitize.jsand override the usage of it? That way we can includeangular-sanitize.jsto the dependency and add the overrides to the main (or add them totextAngular.js).