Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

junior parkruns not being counted in some stats #236

Open
josh-justjosh opened this issue Jan 24, 2020 · 1 comment
Open

junior parkruns not being counted in some stats #236

josh-justjosh opened this issue Jan 24, 2020 · 1 comment

Comments

@josh-justjosh
Copy link

@josh-justjosh josh-justjosh commented Jan 24, 2020

I noticed while checking #235 that junior parkruns don't seem to be counted/included in the following statistics:

  • Average parkrun lat/lon location
  • Countries visited

Perhaps for people under 14, there could be an extra row for average junior parkrun event

@fraz3alpha

This comment has been minimized.

Copy link
Owner

@fraz3alpha fraz3alpha commented Jan 24, 2020

Until we switched to events.json (#197) the extension didn't have the locations of the junior events as they were stored in a separate file on the parkrun website that we didn't pull down. This necessarily meant that anything that required knowing where a junior parkrun was skipped.

The events JSON file does now have them in, but the code within the extension effectively ignores them completely as there is no current mechanism to parse those event and consider different event types where necessary (e.g. the explorer map). Of course anything that just looks at the parkrun name works - as that doesn't need the location - e.g. tourism, alphabeteer etc.., and the volunteer information on the parkrun website doesn't differentiate as to where you volunteered - so that's already combined information.

We are generally of the opinion that they should count as much as a regular parkrun, i.e. not be differentiated as junior/5k stats, and just be one "parkrun", so yes, eventually we'll come back and look at how to fold in junior parkrun properly and get it fully supported.

#50 was where we first started thinking about this, nearly 2 years ago shortly after the extension was first made :) We've had many more discussions between ourselves since, and they haven't been put into that issue, but it's probably a good thing to consider and re-state our thoughts and plans in that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.