From 5cd790704d49b37b6015b3b62ae0f1ee828f381a Mon Sep 17 00:00:00 2001 From: Joe Groocock Date: Sat, 4 Sep 2021 12:33:38 +0100 Subject: [PATCH] test: Disable gometalinter as it fails to install To be replaced in the near future with golangci-lint, which fully replaces gometalinter in terms of functionality, plus adds some more. # gopkg.in/alecthomas/gometalinter.v1 Error: ../../../../pkg/mod/gopkg.in/alecthomas/gometalinter.v1@v1.2.1/main.go:129:69: cannot use loadConfig (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to kingpin.Flag("config", "Load JSON configuration from file.").Action Error: ../../../../pkg/mod/gopkg.in/alecthomas/gometalinter.v1@v1.2.1/main.go:130:104: cannot use disableAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to kingpin.Flag("disable", "Disable previously enabled linters.").PlaceHolder("LINTER").Short('D').Action Error: ../../../../pkg/mod/gopkg.in/alecthomas/gometalinter.v1@v1.2.1/main.go:131:103: cannot use enableAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to kingpin.Flag("enable", "Enable previously disabled linters.").PlaceHolder("LINTER").Short('E').Action Error: ../../../../pkg/mod/gopkg.in/alecthomas/gometalinter.v1@v1.2.1/main.go:135:60: cannot use disableAllAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to kingpin.Flag("disable-all", "Disable all linters.").Action Error: ../../../../pkg/mod/gopkg.in/alecthomas/gometalinter.v1@v1.2.1/main.go:136:58: cannot use enableAllAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to kingpin.Flag("enable-all", "Enable all linters.").Action Signed-off-by: Joe Groocock --- docker/Dockerfile.build | 2 +- misc/make-deps.sh | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/docker/Dockerfile.build b/docker/Dockerfile.build index a863029d4..6a4aefb46 100644 --- a/docker/Dockerfile.build +++ b/docker/Dockerfile.build @@ -8,5 +8,5 @@ ENV PKG_CONFIG_PATH=/opt/rh/rh-ruby22/root/usr/lib64/pkgconfig${PKG_CONFIG_PATH: RUN yum -y install epel-release wget unzip git make which centos-release-scl gcc && sed -i "s/enabled=0/enabled=1/" /etc/yum.repos.d/epel-testing.repo && yum -y install rh-ruby22 && wget -O /opt/go1.16.8.linux-amd64.tar.gz https://storage.googleapis.com/golang/go1.16.8.linux-amd64.tar.gz && tar -C /usr/local -xzf /opt/go1.16.8.linux-amd64.tar.gz RUN mkdir -p $GOPATH/src/github.com/purpleidea && cd $GOPATH/src/github.com/purpleidea && git clone --recursive https://github.com/purpleidea/mgmt -RUN go get -u gopkg.in/alecthomas/gometalinter.v1 && cd $GOPATH/src/github.com/purpleidea/mgmt && make deps && make build +RUN cd $GOPATH/src/github.com/purpleidea/mgmt && make deps && make build CMD ["/bin/bash"] diff --git a/misc/make-deps.sh b/misc/make-deps.sh index 3f31be734..70fc25e14 100755 --- a/misc/make-deps.sh +++ b/misc/make-deps.sh @@ -134,11 +134,6 @@ go get golang.org/x/lint/golint # for `golint`-ing go get golang.org/x/tools/cmd/goimports # for fmt go get github.com/kevinburke/go-bindata/go-bindata # for compiling in non golang files go get github.com/dvyukov/go-fuzz/go-fuzz # for fuzzing the mcl lang bits -if in_ci; then - go get -u gopkg.in/alecthomas/gometalinter.v1 && \ - mv "$(dirname $(command -v gometalinter.v1))/gometalinter.v1" "$(dirname $(command -v gometalinter.v1))/gometalinter" && \ - gometalinter --install # bonus -fi fold_end "Install golang tools" fold_start "Install miscellaneous tools"