Skip to content

Commit 6716bb8

Browse files
fix(plugins/score): 修复了「预期成绩估计」功能无法正常使用的bug
修复了教务系统更新后,「预期成绩估计」功能无法正常使用的bug fix #45
1 parent c361d66 commit 6716bb8

File tree

2 files changed

+18
-12
lines changed

2 files changed

+18
-12
lines changed

src/plugins/score/ExpectedGradesEstimation.vue

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
title='提示',
5757
type='info',
5858
description='您现在还没有添加预期课程~点击下面按钮新增预期课程,就可以估计预期成绩了!',
59-
:show-icon='true'
59+
:show-icon='true',
6060
:closable='false'
6161
)
6262
.input-line-list(v-for='(v, i) in newCourses', :key='i')
@@ -156,10 +156,12 @@ import {
156156
getAllCoursesGPA,
157157
getAllCoursesScore,
158158
getCompulsoryCourses,
159-
getPointByScore
159+
getPointByScore,
160+
reserveHigherCoursesForRetakenCourses,
161+
removeMinorCourses
160162
} from '@/plugins/score/utils'
161163
import { pluck, sum } from 'ramda'
162-
import { requestAllTermsCourseScoreInfoList } from '@/store/actions/request'
164+
import { requestAllPassingScores } from '@/store/actions/request'
163165
import { notifyError } from '@/helper/util'
164166
165167
type NewCourseType = 'compulsory' | 'optional'
@@ -235,13 +237,17 @@ export default class ExpectedGradeEstimation extends Vue {
235237
}
236238
237239
get hasNoError(): boolean {
238-
return this.alerts.every(v => v.type !== 'error')
240+
return this.alerts.every((v) => v.type !== 'error')
239241
}
240242
241243
get allCourses(): CourseScoreRecord[] {
242-
return this.records.reduce(
243-
(acc, cur) => acc.concat(cur.courses),
244-
[] as CourseScoreRecord[]
244+
return reserveHigherCoursesForRetakenCourses(
245+
removeMinorCourses(
246+
this.records.reduce(
247+
(acc, cur) => acc.concat(cur.courses),
248+
[] as CourseScoreRecord[]
249+
)
250+
)
245251
)
246252
}
247253
@@ -349,7 +355,7 @@ export default class ExpectedGradeEstimation extends Vue {
349355
async created(): Promise<void> {
350356
try {
351357
const records = await convertCourseScoreInfoListToScoreRecords(
352-
await requestAllTermsCourseScoreInfoList()
358+
await requestAllPassingScores()
353359
)
354360
this.records = records
355361
this.loadingIsDone = true

src/plugins/score/components/ExpectedGradesEstimation/FourTypeGradeLabels.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
<template lang="pug">
22
.four-type-grade-labels
33
span.gpa-st-tag.label.label-success(
4-
:title='isTipsShown ? `您一共修读了 ${compulsoryCoursesQuantity} 门必修课程,必修加权平均分为 ${compulsoryCoursesScore}` : null'
4+
:title='isTipsShown ? `您一共修读了 ${compulsoryCoursesQuantity} 门属于主修培养方案的必修课程,必修加权平均分为 ${compulsoryCoursesScore}` : null'
55
)
66
| 必修平均分:{{ compulsoryCoursesScore }}
77
|
88
|
99
span.gpa-st-tag.label.label-success(
10-
:title='isTipsShown ? `您一共修读了 ${compulsoryCoursesQuantity} 门必修课程,必修加权平均绩点为 ${compulsoryCoursesGPA}` : null'
10+
:title='isTipsShown ? `您一共修读了 ${compulsoryCoursesQuantity} 门属于主修培养方案的必修课程,必修加权平均绩点为 ${compulsoryCoursesGPA}` : null'
1111
)
1212
| 必修绩点:{{ compulsoryCoursesGPA }}
1313
|
1414
|
1515
span.gpa-st-tag.label.label-purple(
16-
:title='isTipsShown ? `您一共修读了 ${allCoursesQuantity} 门课程,加权平均分为 ${allCoursesScore}` : null'
16+
:title='isTipsShown ? `您一共修读了 ${allCoursesQuantity} 门属于主修培养方案的课程,加权平均分为 ${allCoursesScore}` : null'
1717
)
1818
| 全部平均分:{{ allCoursesScore }}
1919
|
2020
|
2121
span.gpa-st-tag.label.label-purple(
22-
:title='isTipsShown ? `您一共修读了 ${allCoursesQuantity} 门课程,加权平均绩点为 ${allCoursesGPA}` : null'
22+
:title='isTipsShown ? `您一共修读了 ${allCoursesQuantity} 门属于主修培养方案的课程,加权平均绩点为 ${allCoursesGPA}` : null'
2323
)
2424
| 全部绩点:{{ allCoursesGPA }}
2525
</template>

0 commit comments

Comments
 (0)