Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add questions about some ARIA roles and best practices to accessibility quiz #702

Merged
merged 14 commits into from Oct 2, 2023

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 1, 2023

Summary of changes

This PR adds questions about some ARIAs and best practices to the accessibility quiz.

Checklist

  • I have read and followed the contribution guidelines.
  • I have read through the Code of Conduct and agree to abide by the rules.
  • This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
  • My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
  • I have provided a summary of my changes.

Relates to #374

@CBID2 CBID2 changed the title feat: add questions about some ARIA roles feat: add questions about some ARIA roles and best practices to accessibility quiz Oct 1, 2023
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please review the requested changes.
Once those changes have been implemented, then we can merge your PR into main. 👍

src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
CBID2 and others added 11 commits October 1, 2023 19:46
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 2, 2023

Made the changes @jdwilkin4. Will this PR count for Hacktoberfest?

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first contribution to our repository. 🎉
We look forward to future contributions. 👍

@jdwilkin4
Copy link
Contributor

@CBID2

Any repo that has the hacktoberfest topic on it and approves and merges the pr within october counts.
you can learn more about the rules here
https://hacktoberfest.com/participation/

hope that helps

@jdwilkin4 jdwilkin4 merged commit c331153 into freeCodeCamp:main Oct 2, 2023
2 checks passed
@CBID2 CBID2 deleted the adding-accessibility-questions branch October 2, 2023 00:58
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 2, 2023

@CBID2

Any repo that has the hacktoberfest topic on it and approves and merges the pr within october counts. you can learn more about the rules here https://hacktoberfest.com/participation/

hope that helps

Great thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants