Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new sql quiz questions #742

Merged
merged 2 commits into from Oct 5, 2023
Merged

added new sql quiz questions #742

merged 2 commits into from Oct 5, 2023

Conversation

wheeleruniverse
Copy link
Contributor

Summary of changes

#17

  • contributed new SQL questions for use in the FCC Developer Quiz

Checklist

  • I have read and followed the contribution guidelines.
  • I have read through the Code of Conduct and agree to abide by the rules.
  • This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
  • My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
  • I have provided a summary of my changes.

jdwilkin4
jdwilkin4 requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please review the requested changes.
Once those changes have been implemented, then we can merge your PR into main. 👍

src/data/sql-quiz.ts
"What SQL statement contains a valid subquery?",
Answer: "SELECT * FROM employees WHERE wage > (SELECT AVG(wage) FROM employees)",
Distractor1: "SELECT MAX(*) FROM employees",
Distractor2: "SELECT AVG(wage) FROM employees WHERE name IN ('name1', 'name2', 'name3')",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks valid to me
we should alter this one to be one of the wrong answers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that make it a good distractor? An in-clause is not a sub query, but I can still update this question if you would like me too!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think at first glance it looked valid but at second look that makes sense why it isn't.
we could leave it.

Some questions, will have more obviously wrong and right answers why others will take a few more seconds to look at to check for the right answer.

So it is good to have a mixture of both 👍

jdwilkin4
jdwilkin4 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first contribution to our repository. 🎉
We look forward to future contributions. 👍

src/data/sql-quiz.ts
"What SQL statement contains a valid subquery?",
Answer: "SELECT * FROM employees WHERE wage > (SELECT AVG(wage) FROM employees)",
Distractor1: "SELECT MAX(*) FROM employees",
Distractor2: "SELECT AVG(wage) FROM employees WHERE name IN ('name1', 'name2', 'name3')",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think at first glance it looked valid but at second look that makes sense why it isn't.
we could leave it.

Some questions, will have more obviously wrong and right answers why others will take a few more seconds to look at to check for the right answer.

So it is good to have a mixture of both 👍

@jdwilkin4 jdwilkin4 merged commit 6d53af2 into freeCodeCamp:main Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wheeleruniverse @jdwilkin4