Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a quiz about relative unit to accessibilityQuiz #822

Merged
merged 3 commits into from Oct 15, 2023
Merged

Added a quiz about relative unit to accessibilityQuiz #822

merged 3 commits into from Oct 15, 2023

Conversation

Satoshi-Sh
Copy link
Contributor

Summary of changes

Added a quiz about relative unit and absolute measurement to accessibilityQuiz.

Checklist

  • I have read and followed the contribution guidelines.
  • I have read through the Code of Conduct and agree to abide by the rules.
  • This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
  • My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
  • I have provided a summary of my changes.

#374

jdwilkin4
jdwilkin4 requested changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please review the requested changes.
Once those changes have been implemented, then we can merge your PR into main. 👍

src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
src/data/accessibility-quiz.ts Outdated Show resolved Hide resolved
jdwilkin4
jdwilkin4 approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first contribution to our repository. 🎉
We look forward to future contributions. 👍

@jdwilkin4 jdwilkin4 merged commit c2de744 into freeCodeCamp:main Oct 15, 2023
2 checks passed
@Satoshi-Sh
Copy link
Contributor Author

Thanks for the guidance, @jdwilkin4. I'm looking forward to contributing more in the future. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Satoshi-Sh @jdwilkin4