Changes the timelimit between spacebar and last keypress #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojeytonwilliams
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
LGTM 👍
Thanks @shashank1207, I've checked it out locally and this works nicely. This this is a global change (i.e. not just one doc) I'll wait for one more review, just in case I'm missing something obvious.
|
I think it would be better to add an option in the options page of devdocs to change individually the keypress timeout for the spacebar or change the current shortcut of the spacebar, but it could take some time. Meanwhile, we can merge this PR and see if other people think three seconds are too much for wait or not. |
|
@MasterEnoc I am working on it. I will create pull request as soon as it completes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the issue #1553. Changed the allowed timelimit between spacebar and last keypress from 500ms to 3000ms.