Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue about Challenge - Target the same element with multiple jQuery Selectors #10021

Closed
JaeLiao opened this issue Jul 31, 2016 · 3 comments
Closed

Comments

@JaeLiao
Copy link

@JaeLiao JaeLiao commented Jul 31, 2016

Challenge Name

Only add one class with each of your three selectors.

Issue Description

Only the task "Only add one class with each of your three selectors." fails. I think I've done that only one class is added with the the different selectors in my code.

Browser Information

Chrome 52.0.2743.82 m
Win10
Desktop

Your Code

<script>
  $(document).ready(function() {
    $("button").addClass ("animated");
    $(".btn").addClass ("shake");
    $("#target1").addClass ("btn-primary");
  });
</script>

<!-- Only change code above this line. -->

<div class="container-fluid">
  <h3 class="text-primary text-center">jQuery Playground</h3>
  <div class="row">
    <div class="col-xs-6">
      <h4>#left-well</h4>
      <div class="well" id="left-well">
        <button class="btn btn-default target" id="target1">#target1</button>
        <button class="btn btn-default target" id="target2">#target2</button>
        <button class="btn btn-default target" id="target3">#target3</button>
      </div>
    </div>
    <div class="col-xs-6">
      <h4>#right-well</h4>
      <div class="well" id="right-well">
        <button class="btn btn-default target" id="target4">#target4</button>
        <button class="btn btn-default target" id="target5">#target5</button>
        <button class="btn btn-default target" id="target6">#target6</button>
      </div>
    </div>
  </div>
</div>

Screenshot

issue

@ghost
Copy link

@ghost ghost commented Jul 31, 2016

Thanks for reporting this @JaeLiao, this is because our tests don't seem to allow for spaces in between .addClass and (className).
We should adjust the tests to allow spaces 👍

@dhcodes
Copy link
Contributor

@dhcodes dhcodes commented Aug 2, 2016

Tested locally and the added regex in the PR above seems to fix this. Hopefully it's gtg.

@katbryers
Copy link

@katbryers katbryers commented Nov 6, 2016

Having the same error happen except none of my check list on the side will change.
and it won't run the test at all.

screen shot 2016-11-06 at 6 10 51 pm

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants