Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the instruction #12576

Closed
arvind00 opened this issue Jan 17, 2017 · 10 comments
Closed

Typo in the instruction #12576

arvind00 opened this issue Jan 17, 2017 · 10 comments

Comments

@arvind00
Copy link

@arvind00 arvind00 commented Jan 17, 2017

constructing-strings-with-variables

Issue Description

There is a spelling mistake in the instruction given.

  • Here is the extract of the Instruction:

Set myName to a string equal to your name and build myStr with myName between the strings "My name is " and " and I am swell!"

  • Expected last word in the instruction: well
  • Actual last word in the instruction: swell

Here well is expected instead of swell because, the context is set in the starting of the code as:

var ourName = "Free Code Camp";
var ourStr = "Hello, our name is " + ourName + ", how are you?";

// Only change code below this line
var myName;
var myStr;

Browser Information

  • Browser Name, Version:
  • Operating System:
  • Mobile, Desktop, or Tablet:

Your Code

 
 
 

Screenshot

@OFFLlNE
Copy link

@OFFLlNE OFFLlNE commented Jan 17, 2017

Thanks for reporting that.

I think they meant it to be "swell" not well.
Urban Dictionary : swell => adj. Fantastic, great, wonderful, et.

Google:
adjective (NORTH AMERICAN) informal
excellent; very good.
"you're looking swell"

@raisedadead
Copy link
Member

@raisedadead raisedadead commented Jan 17, 2017

Thanks @arvind00.

@OFFLlNE agreed.

Although I believe a lot of campers are non-native English speakers. We might as well change this, while this is not a huge issue with the challenge itself.

/cc @freeCodeCamp/moderators worth changing? If yes, let's tag it first timers?

@arvind00
Copy link
Author

@arvind00 arvind00 commented Jan 17, 2017

Thanks @OFFLlNE and @raisedadead .
I should have referred a dictionary, before posting it.
So, shall I keep the issue open or close it?

@dhcodes
Copy link
Contributor

@dhcodes dhcodes commented Jan 17, 2017

Feels like bike-shedding to me, but if it looks like a typo to a lot of people, then I'm fine with a first-timer PR for it.

@caravinci caravinci changed the title Typo in the the instruction Typo in the instruction Jan 17, 2017
@caravinci
Copy link
Member

@caravinci caravinci commented Jan 17, 2017

If not for the sake of promoting easy contributions, then just so that non-natives won't be confused (which increases friction and makes their learning more difficult).

@TheeMattOliver
Copy link
Contributor

@TheeMattOliver TheeMattOliver commented Jan 17, 2017

I'll take it. 'Swell' is fine (I am kind of an American English Usage buff, and this is an important field in pedagogy!), but I'd like to claim this just so I can get the practice with contributing.

@caravinci
Copy link
Member

@caravinci caravinci commented Jan 17, 2017

@TheeMattOliver that's swell! PR away 😃

@arvind00
Copy link
Author

@arvind00 arvind00 commented Jan 17, 2017

Thanks @everyone. Closing the issue.

@arvind00 arvind00 closed this Jan 17, 2017
@raisedadead raisedadead reopened this Jan 17, 2017
@raisedadead
Copy link
Member

@raisedadead raisedadead commented Jan 17, 2017

@arvind00 do not close the issue, this will be closed with a pull request (PR).

@arvind00
Copy link
Author

@arvind00 arvind00 commented Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants