Broken Tests on challenge Basic CSS: Use Attribute Selectors to Style Elements

[svjmtn]

Describe your problem and how to reproduce it:
This is expected to work, and it works in the preview.
There is a space before and after the = symbol.

  [type = 'checkbox'] {
    margin-top: 10px;
    margin-bottom: 15px;
  }

It fails tests with this error, although it is expected to pass.

// running tests
The type attribute selector should be used to select the checkboxes.

The same code without the spaces passes.

Add a Link to the page with the problem:
https://www.freecodecamp.org/learn/responsive-web-design/basic-css/use-attribute-selectors-to-style-elements

Tell us about your browser and operating system:

• Browser Name: Google Chrome
• Browser Version: 79.0.3945.130
• Operating System: Fedora 31

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

[ShaunSHamilton]

Whilst I agree there is no reason the tests should not pass, I think it is important to note that having space on either side of the = is not good syntax, and could cause issue with integration with SASS. HTML is just so forgiving.
https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors

[svjmtn]

Oh, I didn't know that wasn't good practice. It would be nice if it was mentioned in the lesson. I agree, if it's not good practice then, it would be best to fail the test and mention such an error message.

[moT01]

I don't think it's necessary to point out the best practices here. This is the basic css section so if it's valid css, it should pass the tests. I think just adjusting the one test would be enough. Here's the file

[jaredwils]

could I possibly work on this issue?

[moT01]

go for it @jaredwils

[kshashwat007]

Hi, Wanted to ask if its possible to work on this issue?

[ahmaxed]

@kshashwat007, please go ahead 👍. No assignment is necessary as described in our contribution docs. The first comprehensive PR will be considered for review.

[moT01]

There's an actually an open PR to fix this @kshashwat007. I would look for another issue.