Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: incorrect relative linking in translations #39785

Closed
raisedadead opened this issue Oct 2, 2020 · 7 comments
Closed

docs: incorrect relative linking in translations #39785

raisedadead opened this issue Oct 2, 2020 · 7 comments
Labels
scope: docs Codebase and other documentation type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@raisedadead
Copy link
Member

To add to this issue:

Malformed URL appears 🎉

Originally posted by @SKY020 in #39784 (comment)

@raisedadead raisedadead added scope: docs Codebase and other documentation type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. labels Oct 2, 2020
@raisedadead
Copy link
Member Author

This should be a missed alias config or something. I will check this, thanks for letting me know.

@ZITANIMohamed98
Copy link

Arabic translation have alot of grammatical errors can i work on this ?

@ShaunSHamilton
Copy link
Member

@ZITANIMohamed98 Thank you, for your interest in contributing. This issue is not related to the word translations of any language, but the routing of the page.

So, I recommend you find an issue with either a help wanted or first-timers only label. Those are open to contribution. Also, if you have not already, take a read of the contributing docs

@raisedadead
Copy link
Member Author

This should now have been resolved with a simplified navigation.

@ShaunSHamilton
Copy link
Member

@raisedadead This seems to be working well now. Only things I have noticed:
image

⬆️ Moderator Handbook children end up as Reply Template children. Not a big deal; nothing breaks.

  1. Translations do not have the Introduction page: https://contribute.freecodecamp.org/#/i18n/Chinese/README

@ShaunSHamilton
Copy link
Member

Also, if you traverse from a right-to-left language (Arabic, Chinese), then go to English, the text remains _right-to-left:
image

@raisedadead
Copy link
Member Author

Thanks Shaun. Have some fixes on the way, some need to be investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs Codebase and other documentation type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

No branches or pull requests

3 participants