Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration Form Step 47 may be broken in Safari #49937

Closed
bbsmooth opened this issue Apr 3, 2023 · 0 comments · Fixed by #49959
Closed

Registration Form Step 47 may be broken in Safari #49937

bbsmooth opened this issue Apr 3, 2023 · 0 comments · Fixed by #49959
Labels
other: device specific Browser, Device, OS specific issues. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@bbsmooth
Copy link
Contributor

bbsmooth commented Apr 3, 2023

Describe the Issue

I've come across two forum posts from Safari users in the past few days saying that they can't pass step 47 even though their CSS is correct.

https://forum.freecodecamp.org/t/learn-html-forms-by-building-a-registration-form-step-47/602433

https://forum.freecodecamp.org/t/learn-html-forms-by-building-a-registration-form-step-47/601821

Based on the hint they are getting, the test that is not passing is:

assert(borderBottom === 'none' || borderBottom === 'medium none');

I'm wondering if Safari has recently changed the string being returned for the border properties when set to none? I don't have a mac so I can't test this for myself. Opening this issue with the hopes that a Safari user can figure out what is going on here. Should be tested on a very recent version of Safari.

Affected Page

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-html-forms-by-building-a-registration-form/step-47

Your code

fieldset:last-of-type { 
  border-bottom: none;
}

This is the correct CSS but it is apparently not passing for Safari users.

Expected behavior

Correct CSS should pass.

Screenshots

No response

System

For both posters, user agent is:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.4 Safari/605.1.15

Additional context

No response

@bbsmooth bbsmooth added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. other: device specific Browser, Device, OS specific issues. labels Apr 3, 2023
@Sboonny Sboonny removed the status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other: device specific Browser, Device, OS specific issues. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants