Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn an Image into a Link #9433

Closed
mikerubino4000 opened this issue Jun 28, 2016 · 5 comments
Closed

Turn an Image into a Link #9433

mikerubino4000 opened this issue Jun 28, 2016 · 5 comments

Comments

@mikerubino4000
Copy link

@mikerubino4000 mikerubino4000 commented Jun 28, 2016

Challenge Turn an Image into a Link has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

My code:

<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">
<style>
  .red-text {
    color: red;
  }

  h2 {
    font-family: Lobster, Monospace;
  }

  p {
    font-size: 16px;
    font-family: Monospace;
  }

  .thick-green-border {
    border-color: green;
    border-width: 10px;
    border-style: solid;
    border-radius: 50%;
  }

  .smaller-image {
    width: 100px;
  }
</style>

<h2 class="red-text">CatPhotoApp</h2>

<a href="#"><img src="https://bit.ly/fcc-running-cats"></a>

<p>Click here for <a href="#">cat photos</a>.</p>

<img class="smaller-image thick-green-border" src="https://bit.ly/fcc-relaxing-cat">

<p class="red-text">Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.</p>
<p class="red-text">Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.</p>
@raisedadead
Copy link
Member

@raisedadead raisedadead commented Jun 28, 2016

Thanks for reporting @mikerubino4000 but your code is not correct, please consult Help Chat Room.

Thanks and Happy Coding!

@arku
Copy link
Contributor

@arku arku commented Jun 28, 2016

The instructions aren't enough for this challenge. There should be a line of instruction before the tests. Something along the lines of "Place the existing image within a anchor element" would be better.

We might also want to consider changing the description of the first test so it doesn't replicate the instruction text.

@raisedadead
Copy link
Member

@raisedadead raisedadead commented Jun 28, 2016

Thanks @arun1595 I agree, a simple change would make the instruction a bit more clear.
The first text instruction is pretty okay though

First timers there you go

Add a line after this line:

Place the existing image element within an anchor element.

@RyanWillDev
Copy link
Contributor

@RyanWillDev RyanWillDev commented Jun 28, 2016

I can take care of this as my first contribution to an Open Source project.

@raisedadead
Copy link
Member

@raisedadead raisedadead commented Jun 28, 2016

@RyanWillDev Awesome, please checkout Guidelines for Contributing and reach out to the Contributors Chat room if you need any assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants