Skip to content

fix(URLs): Changed protocol relative URLs to HTTPS URLs - #16573

Merged
raisedadead merged 1 commit into
freeCodeCamp:stagingfrom
tarun7singh:fix/relative-protocol-URLs
Jan 25, 2018
Merged

raisedadead merged 1 commit into
freeCodeCamp:stagingfrom
tarun7singh:fix/relative-protocol-URLs

Conversation

@tarun7singh

@tarun7singh tarun7singh commented Jan 25, 2018 •

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: None

Closes #16522

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #16522

Description

Changed all protocol relative URLs to HTTPS URLs.
For example
<script src="//code.jquery.com/jquery-2.2.3.min.js"></script> to
<script src="https://code.jquery.com/jquery-2.2.3.min.js"></script>
Changes are not breaking any site functionality or any links.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 25, 2018
@Bouncey

Bouncey commented Jan 25, 2018

Copy link
Copy Markdown
Member

LGTM 👍

@raisedadead raisedadead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ ✨ LGTM. ✨ ✨

Thanks @tarun7singh

Happy Contributing!

@raisedadead
raisedadead merged commit 4346de6 into freeCodeCamp:staging Jan 25, 2018
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 25, 2018
@tarun7singh
tarun7singh deleted the fix/relative-protocol-URLs branch January 26, 2018 07:18
@QuincyLarson

Copy link
Copy Markdown
Contributor

@tarun7singh Excellent work! Thanks for your contribution!

ValeraS pushed a commit to ValeraS/freeCodeCamp that referenced this pull request Oct 12, 2018
…rotocol-URLs

fix(URLs): Changed protocol relative URLs to HTTPS URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants