Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos and added a missing section #24548

Merged
merged 2 commits into from Jul 11, 2019

Conversation

Projects
None yet
3 participants
@ricardotenorio
Copy link
Contributor

commented Oct 20, 2018

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

@RandellDawson

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Thank you for creating this PR. However, since it was created, the underlying document has changed. Can you please review and resolve the current merge conflicts? It could be the changes to the underlying document are so significant that your changes are no longer relevant. If the latter is the case, it might be easier to just close this PR and create a new PR with any changes you still feel are important to make.

If you need any assistance or have questions about resolving the merge conflicts, please reply back or contact someone in the Contributors Room on Gitter.

Thank you.

@RandellDawson RandellDawson merged commit e2e69c2 into freeCodeCamp:master Jul 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RandellDawson

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.