Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide/russian/cpp/index.md translation improves #33593

Merged
merged 3 commits into from Jul 3, 2019

Conversation

Projects
None yet
4 participants
@everthinq
Copy link
Contributor

commented Oct 31, 2018

freeCodeCamp/freeCodeCamp/guide/russian/cplusplus/index.md translation improves

I've done it in more readable way and translated missing parts.

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

guide/russian/cpp/index.md translation improves
freeCodeCamp/freeCodeCamp/guide/russian/cplusplus/index.md translation improves

I've done it in more readable way and translated missing parts.
@RandellDawson

This comment has been minimized.

Copy link
Member

commented Dec 1, 2018

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

@RandellDawson

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@greggubarev Can you review this PR? It has a big merge conflict. The most important thing is, regardless what parts you end up keeping, make sure to replace the following:

![Img](https://i.imgur.com/d1liGwI.png)

with:

![Img](https://cdn-media-1.freecodecamp.org/imgr/d1liGwI.png)

@RandellDawson RandellDawson requested a review from greggubarev Jun 12, 2019

@greggubarev
Copy link
Member

left a comment

LGTM 👍 🎯

@greggubarev
Copy link
Member

left a comment

Thank you for the PR 🎉
We're happy to accept these changes and look forward to your future contributions 👏

Happy coding! :octocat:

@RandellDawson

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

@greggubarev There can not be a blank line above the front matter. This must be removed or the Travis build will fail (as it is doing now).

@RandellDawson RandellDawson merged commit 2d80240 into freeCodeCamp:master Jul 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.