Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Navbar Alignment in Night Mode on Curriculum Page #34341

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
3 participants
@Casva
Copy link
Contributor

commented Nov 15, 2018

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #29296

The problem wasn't actually with the navbar itself, but the alignment of the div below it.
You can actually see this in bright mode as well, it's just that the colours happen to be matching.
The top margin was 2px too large so I shortened it.

Also yes, despite what I commented in the issue you can't actually see this bug when you run it locally
(I replicated the error by increasing the top margin by 2 pixels)
So just in case, I shrunk the margin by 4px 馃槂

@raisedadead

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

Hi @Casva

Thanks for the PR. Can you resolve the merge conflict?

@raisedadead raisedadead force-pushed the Casva:issue-29296 branch from 1db8b1c to d53c774 Jan 15, 2019

@raisedadead

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

Landed in d53c774

@raisedadead raisedadead merged commit d53c774 into freeCodeCamp:master Jan 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.