Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Github -> GitHub (Spanish) #35182

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
5 participants
@lipis
Copy link
Contributor

commented Feb 13, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

@lipis

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

After we merge all those.. I'll do a final check on the whole project again :)

title: React TypeChecking with PropTypes
localeTitle: Reaccionar TypeChecking con PropTypes
---
## Reaccionar PropTypes

This comment has been minimized.

Copy link
@lipis

lipis Feb 13, 2019

Author Contributor

Still not sure what is going on here.. but the result looks legit! Some hidden character..

This comment has been minimized.

Copy link
@RandellDawson

RandellDawson May 9, 2019

Member

@lipis Getting close to merging this one. What is the issue you are concerned about here?

This comment has been minimized.

Copy link
@lynxlynxlynx

lynxlynxlynx May 10, 2019

Member

React shouldn't be translated. TypeChecking is bad already in the original.

This comment has been minimized.

Copy link
@RandellDawson

RandellDawson May 10, 2019

Member

@lynxlynxlynx If you look at the changes, it does not look like what shows above. I think this is a non-issue.

@RandellDawson

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@lynxlynxlynx It would be very helpful if you could review the following PRs which make changes to one or more of the same files on this PR. Once all of those have been closed/merged, then we can resolve any merge conflicts that result on this PR. We would really like to get this PR merged quickly since it affects so many files (43). Thanks in advance.

#20857
#25138
#26280
#26477
#26611
#30207
#30715
#31763
#31778
#31927
#34099

@lynxlynxlynx

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

Most are done, one requiring further work from the author and 3 being the ones touching how-to-setup-freecodecamp-locally.md: #31927 #30715 #25138 . Those need someone with a better command of the language.

@RandellDawson

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

@lynxlynxlynx Thanks for the fast turn-around for these. Also, whoever reviews those 3 how-to-setup-freecodecamp-locally.md should validate the English master version has not changed enough to make any of the changes obsolete.

@RandellDawson

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

@lipis Don't worry about any merge conflicts until the other 4 PRs we are waiting on have been closed/merged. I want to take care of any merge conflicts.

@RandellDawson

This comment has been minimized.

Copy link
Member

commented May 10, 2019

@raisedadead There are still 3 outstanding earlier PRs (#31927 #30715 #25138 ) which have changes to one or more of the same files as this PR. They all already have merge conflicts and many of the documents' English version have changed significantly since these PRs have been created, so the translations may not even be relevant anymore. My question is, can we go ahead merge this PR?

@raisedadead

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Yes please.

@RandellDawson
Copy link
Member

left a comment

LGTM

@RandellDawson RandellDawson merged commit 4101d5c into freeCodeCamp:master May 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lipis lipis deleted the lipis:gh-spanish branch May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.