New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add legacy project map #35608
fix: add legacy project map #35608
Conversation
@ahmadabdolsaheb when you get a minute, it would be awesome if you add any open issues and pull-requests on this to the OP (with closes tag, or suitable). We should track all of these and close when this lands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add some tests to make this solid.
@raisedadead, what kind of tests. do you mean ui tests like snapshots? could you give me an example of what you have in mind from our codebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a discussion with @ahmadabdolsaheb about what the expected output was supposed to be...
[x] - full stack certs are not claimable - fixed
[x] - legacy certs are not claimable - fixed
[x] - new full stack gets applied automatically - fixed
[x] - legacy full stack cert is removed - fixed
The issues listed in the PR...
#35410 - Not sure exactly what is meant in this issue - probably best for @raisedadead to take a look at this one.
#17300 - The first part of the issue looks fixed - the legacy certs do show up. But there does appear to be an issue with the second part - I reset my local account and the cert area still shows up in my profile...
#18253 - It looks like the PR fixes this for someone who gets the full stack cert (legacy full stack doesn't show up) - not positive if it will remove the cert for someone who already has it - I have to assume it will, but I could not test it.
Overall it looks real good @ahmadabdolsaheb!
474705d
to
0d82d0a
Compare
Closes #35410
Closes #17300
Closes #18253