Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add legacy project map #35608

Merged
merged 16 commits into from Jun 11, 2019
Merged

Conversation

ahmaxed
Copy link
Member

@ahmaxed ahmaxed commented Mar 15, 2019

Closes #35410
Closes #17300
Closes #18253

@ahmaxed ahmaxed marked this pull request as ready for review March 28, 2019 08:57
@ahmaxed ahmaxed requested review from a team, raisedadead and Bouncey March 28, 2019 08:58
@raisedadead raisedadead added type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping. platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. release: next/beta labels Mar 28, 2019
@raisedadead
Copy link
Member

@ahmadabdolsaheb when you get a minute, it would be awesome if you add any open issues and pull-requests on this to the OP (with closes tag, or suitable). We should track all of these and close when this lands.

Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some tests to make this solid.

@ahmaxed
Copy link
Member Author

ahmaxed commented Mar 29, 2019

@raisedadead, what kind of tests. do you mean ui tests like snapshots? could you give me an example of what you have in mind from our codebase?

Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a discussion with @ahmadabdolsaheb about what the expected output was supposed to be...
[x] - full stack certs are not claimable - fixed
[x] - legacy certs are not claimable - fixed
[x] - new full stack gets applied automatically - fixed
[x] - legacy full stack cert is removed - fixed
Screen Shot 2019-05-07 at 8 59 12 AM

The issues listed in the PR...
#35410 - Not sure exactly what is meant in this issue - probably best for @raisedadead to take a look at this one.

#17300 - The first part of the issue looks fixed - the legacy certs do show up. But there does appear to be an issue with the second part - I reset my local account and the cert area still shows up in my profile...
Screen Shot 2019-05-07 at 9 15 47 AM

#18253 - It looks like the PR fixes this for someone who gets the full stack cert (legacy full stack doesn't show up) - not positive if it will remove the cert for someone who already has it - I have to assume it will, but I could not test it.

Overall it looks real good @ahmadabdolsaheb!

@raisedadead raisedadead self-requested a review May 7, 2019 15:34
@raisedadead raisedadead merged commit 0d82d0a into freeCodeCamp:master Jun 11, 2019
@ahmaxed ahmaxed deleted the fix/port-legacy-cert branch October 30, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping.
Projects
None yet
3 participants