Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct cert date for legacy data visualization #35728

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@ahmadabdolsaheb
Copy link
Member

commented Apr 1, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #34890
Closes #17424

@ahmadabdolsaheb ahmadabdolsaheb requested a review from moT01 Apr 1, 2019

@ahmadabdolsaheb ahmadabdolsaheb requested a review from freeCodeCamp/dev-team as a code owner Apr 1, 2019

@moT01
Copy link
Member

left a comment

This appears to have fixed the issue...

current live site:
Screen Shot 2019-04-02 at 8 46 16 AM

local test of this branch:
Screen Shot 2019-04-02 at 8 46 43 AM

My tests felt a bit "hacky", but it looks like it worked.

@raisedadead raisedadead merged commit b4d3e6d into freeCodeCamp:master Apr 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.