Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded guides for some APIs and Microservices challenges and fixed links to the source files #36131

Merged
merged 12 commits into from Jul 2, 2019
Merged

Expanded guides for some APIs and Microservices challenges and fixed links to the source files #36131

merged 12 commits into from Jul 2, 2019

Conversation

sudiptog81
Copy link
Contributor

I certify that:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

@sudiptog81 sudiptog81 changed the title Expanded guides for two Basic Node and Express challenges and fixed links to the source files Expanded guides for Basic Node and Express challenges and fixed links to the source files May 26, 2019
@sudiptog81 sudiptog81 changed the title Expanded guides for Basic Node and Express challenges and fixed links to the source files Expanded guides for some APIs and Microservices challenges and fixed links to the source files May 26, 2019
@RandellDawson
Copy link
Member

Attention Mods: There are two earlier PRs (#35315 and #35322) which make changes to one or more files on this PR. Please review/merge them first. This may result in merge conflicts on this PR, but the OP or you can resolve then.

@RandellDawson RandellDawson added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Jun 25, 2019
@RandellDawson RandellDawson removed the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Jun 25, 2019
@moT01
Copy link
Member

moT01 commented Jul 1, 2019

I'm wondering if we should remove all the links at the bottom that say "Help our community expand these hints and guides" - since there will be a link and info like that at the bottom of all the guide articles with the latest master.

moT01
moT01 approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sudiptog81 - congratulations on your first contribution to freeCodeCamp! 🎉

@moT01 moT01 merged commit 29823fe into freeCodeCamp:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sudiptog81 @RandellDawson @moT01 @camperbot