Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(client): combine donate & donate-other pages into a single page #36137
This is what I came up with for a first draft, I am sure there will need to be revisions - but I think this is at least a decent starting point.
Thanks for the opportunity to contribute,
referenced this pull request
May 28, 2019
changed the title
fix(client)/#35667: Combine donate page & donate-other pages into a single page (freecodecamp.org/donate).
May 28, 2019
raisedadead left a comment •
Copy That. Thanks for the Speedy Response.
Regarding Page Re-Render @
As I brainstorm other methods, this really seems to be the simplest, I don't even have to add an id tag to the form or something to target with
Do you still want me to change it? Or, if it truly behaves as I described, is this a suitable solution?
I'll work on the other items in the meantime.
I really appreciate your time,
I somehow screwed up a commit or something on my end, and had to figure it out. It seems ok on my end now, but I fear it may have messed up this PR somehow. All the checks have passed though, so I'm thinking I fixed it.
Sorry, some parts of this github thing still get me every now and again...
Anyways, I have updated the PR with your requested text edit and moved
So, at this moment, all I am waiting for is your approval of my edits, and your thoughts regarding the use of
Thanks for these changes, I think we are looking good w.r.t the link. Sorry about the confusion. I dropped that suggestion of the top of my head.
Someone from @freeCodeCamp/dev-team will QA this soon. As you may know we have a huge backlog of PRs, thanks for your hard work and time in preparing the PR.
You should hangout with us in Contributors Chat room to learn more about contributing to freeCodeCamp.