Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update footer and about page: replace link to Medium with link to News #36288

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
2 participants
@aenon
Copy link

commented Jun 13, 2019

This minor change updates the link to Medium (https://medium.freecodecamp.org) with the link to News (https://www.freecodecamp.org/news).

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Related to #35397

@aenon aenon requested a review from freeCodeCamp/dev-team as a code owner Jun 13, 2019

@raisedadead
Copy link
Member

left a comment

@aenon

Thanks for the pull-request. I recommend you start by reading our Guidelines for Contributing.

Then on you can

  • Address the review comment.
  • Test this locally and fix the linting errors.

Also, while you are at it, this will be a good read: https://chris.beams.io/posts/git-commit

Happy Contributing!

Show resolved Hide resolved client/src/components/Footer/index.js Outdated
Update client/src/components/Footer/index.js
Co-Authored-By: mrugesh <1884376+raisedadead@users.noreply.github.com>
@raisedadead

This comment has been minimized.

Copy link
Member

commented Jun 16, 2019

Hi @aenon closing this. We have already landed a fix in this commit 0ffca02

Happy contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.