Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: News indexing script #36512

Merged

Conversation

@scissorsneedfoodtoo
Copy link
Contributor

commented Jul 25, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

@scissorsneedfoodtoo scissorsneedfoodtoo requested a review from freeCodeCamp/dev-team as a code owner Jul 25, 2019
@CleoAguiar

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

All checks have failed. Please put a x between square brackets in your pull requests text.
Replace [ ] to [x]

@scissorsneedfoodtoo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

@CleoAguiar, thank you for taking a look at this. You're right, I should remember to put an x between the brackets or check them off individually.

I believe the check failed due to a linting error. I'll fix this, along with updating the News theme and search bar to account for the changed property names in each article object.

@scissorsneedfoodtoo scissorsneedfoodtoo force-pushed the scissorsneedfoodtoo:feat/news-indexing-script branch from 3545740 to 080df3b Jul 29, 2019
@scissorsneedfoodtoo scissorsneedfoodtoo force-pushed the scissorsneedfoodtoo:feat/news-indexing-script branch from 080df3b to 1c876ad Jul 29, 2019
@raisedadead raisedadead merged commit 9f372d0 into freeCodeCamp:master Jul 29, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@scissorsneedfoodtoo scissorsneedfoodtoo deleted the scissorsneedfoodtoo:feat/news-indexing-script branch Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.