Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extend linting to cover react hooks #36725

Merged

Conversation

@ojeytonwilliams
Copy link
Contributor

commented Aug 30, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Since we're looking to start using React hooks in #36722, I figured we should lint them.

@ojeytonwilliams ojeytonwilliams requested a review from freeCodeCamp/dev-team as a code owner Aug 30, 2019
@gitpod-io

This comment has been minimized.

Copy link

commented Aug 30, 2019

@ojeytonwilliams

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

I gave the review in Gitpod button a push. It's pretty fantastic!

@raisedadead

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

It sure is thanks to @svenefftinge and @jankeromnes for the integration! 🚀

@raisedadead raisedadead merged commit f50ac6e into freeCodeCamp:master Aug 30, 2019
2 checks passed
2 checks passed
Gitpod Open an online workspace in Gitpod
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raisedadead

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

I just used GitPod's Interface to approve and merge the PR and this is pretty darn slick!!

@ojeytonwilliams ojeytonwilliams deleted the ojeytonwilliams:chore/lint-react-hooks branch Aug 30, 2019
@ojeytonwilliams

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

I hadn't realised you could do that through GitPod. So, yeah, thanks @svenefftinge and @jankeromnes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.