Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix link path to other translations in document-quick-reference #36767

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@unhappychoice
Copy link
Contributor

unhappychoice commented Sep 8, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Description

Fix link path

#36716 renames docs/lang/README.md to docs/lang/document-quick-reference.md.
But links to other translations seems to be not changed and broken.
So, I fixed that.

Fix link to english version

Some translations has link to <td><a href="/CONTRIBUTING.md"> English </a></td>.
But I think this is wrong, so I fixed that.

Add all the translation

Since some document-quick-reference do not have links to all the translated document-quick-reference, I added the links.

@gitpod-io

This comment has been minimized.

Copy link

gitpod-io bot commented Sep 8, 2019

@unhappychoice

This comment has been minimized.

Copy link
Contributor Author

unhappychoice commented Sep 8, 2019

Add all the translation

Due to adding more languages, the style is a little bit broken.

スクリーンショット 2019-09-08 12 15 11

Should I fix it?

@raisedadead raisedadead merged commit 49d27af into freeCodeCamp:master Sep 8, 2019
2 checks passed
2 checks passed
Gitpod Open an online workspace in Gitpod
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raisedadead

This comment has been minimized.

Copy link
Member

raisedadead commented Sep 8, 2019

Hi @unhappychoice thanks for the PR.

We are removing these quick reference guides soon (in favor of a better structure), I think the styles will not be relevant then.

@unhappychoice unhappychoice deleted the unhappychoice:fix-dcoment-links branch Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.