Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test rendered output instead of state in react write a simple counter… #36791

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@jzabala
Copy link
Contributor

commented Sep 15, 2019

… challenge

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #36782

@gitpod-io

This comment has been minimized.

Copy link

commented Sep 15, 2019

@scissorsneedfoodtoo

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

@jzabala, thank you for taking the time to improve this challenge. Just checked this out locally and everything LGTM. The code from #36782 that mutates the state directly no longer passes the tests. With these changes users must use setState like they were taught in previous lessons.

@jzabala

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2019

@jzabala, thank you for taking the time to improve this challenge. Just checked this out locally and everything LGTM. The code from #36782 that mutates the state directly no longer passes the tests. With these changes users must use setState like they were taught in previous lessons.

Thank you very much @scissorsneedfoodtoo for taking the time to do the test on this one 👍🏼

@moT01
moT01 approved these changes Oct 9, 2019
Copy link
Member

left a comment

LGTM @jzabala 🎉 Thanks for fixing this and congratulations on your first contribution to freeCodeCamp! 🎉

@moT01 moT01 merged commit e9bbcc5 into freeCodeCamp:master Oct 9, 2019
2 checks passed
2 checks passed
Gitpod Open an online workspace in Gitpod
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jzabala

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

LGTM @jzabala 🎉 Thanks for fixing this and congratulations on your first contribution to freeCodeCamp! 🎉

That is awesome. Thank you very much @moT01 for merging it 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.