Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: .gitignore and image enhancements #37075

Merged
merged 12 commits into from Oct 7, 2019

Conversation

@aravindvnair99
Copy link
Contributor

commented Oct 7, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #37074

ImgBotApp and others added 8 commits Oct 1, 2019
*Total -- 160.17kb -> 143.42kb (10.46%)

/client/src/assets/images/square_puck.png -- 47.96kb -> 33.81kb (29.5%)
/api-server/public/images/freeCodeCamp-puck.svg -- 2.22kb -> 2.03kb (8.51%)
/client/src/assets/images/freeCodeCamp-404.svg -- 3.80kb -> 3.66kb (3.73%)
/client/static/fonts/glyphicons-halflings-regular.svg -- 106.19kb -> 103.92kb (2.14%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
@aravindvnair99 aravindvnair99 requested a review from freeCodeCamp/dev-team as a code owner Oct 7, 2019
@gitpod-io

This comment has been minimized.

Copy link

commented Oct 7, 2019

.gitignore Outdated Show resolved Hide resolved
@aravindvnair99 aravindvnair99 requested a review from raisedadead Oct 7, 2019
Copy link
Member

left a comment

New lines at the eof

.gitignore Outdated Show resolved Hide resolved
api-server/public/images/freeCodeCamp-puck.svg Outdated Show resolved Hide resolved
client/src/assets/images/freeCodeCamp-404.svg Outdated Show resolved Hide resolved
aravindvnair99 and others added 3 commits Oct 7, 2019
Co-Authored-By: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-Authored-By: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-Authored-By: mrugesh <1884376+raisedadead@users.noreply.github.com>
@aravindvnair99

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

New lines at the eof

@raisedadead Committed the changes. Should I update glyphicons-halflings-regular.svg with blank-at-eof as well?

@aravindvnair99 aravindvnair99 requested a review from raisedadead Oct 7, 2019
@raisedadead raisedadead changed the title .gitignore and image enhancements chore: .gitignore and image enhancements Oct 7, 2019
@raisedadead raisedadead merged commit d0cda58 into freeCodeCamp:master Oct 7, 2019
2 checks passed
2 checks passed
Gitpod Open an online workspace in Gitpod
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.