Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle invalid Algolia keys gracefully in dev #37088

Conversation

@ojeytonwilliams
Copy link
Contributor

commented Oct 7, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Invalid keys throw an error during a production build, but just cause invalid PropTypes and build warnings in development.

@raisedadead I wasn't sure precisely how the environment variables are set in production, so I made the assumption that it wasn't by a .env file. Hence the replacement of require('dotenv').config(); in gatsby-node.

Closes #37076

Invalid keys throw an error in production, but just cause invalid
PropTypes and build warnings in development.
@ojeytonwilliams ojeytonwilliams requested a review from freeCodeCamp/dev-team as a code owner Oct 7, 2019
@gitpod-io

This comment has been minimized.

Copy link

commented Oct 7, 2019

@raisedadead raisedadead merged commit e72855d into freeCodeCamp:master Oct 8, 2019
2 checks passed
2 checks passed
Gitpod Open an online workspace in Gitpod
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ojeytonwilliams ojeytonwilliams deleted the ojeytonwilliams:fix/handle-missing-algolia-keys branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.