Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): changed container to container2 in auto-fit challenge test #37483

Conversation

@RandellDawson
Copy link
Member

RandellDawson commented Oct 23, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

This PR fixes a bug in the [Create Flexible Layouts Using auto-fit] challenge. The test was checking the container class instead of the container2 class, which allowed users to modify container with auto-fit and incorrectly pass the challenge.

This issue was first reported by a user in this forum topic.

@gitpod-io

This comment has been minimized.

Copy link

gitpod-io bot commented Oct 23, 2019

@gitpod-io

This comment has been minimized.

Copy link

gitpod-io bot commented Oct 27, 2019

@RandellDawson RandellDawson force-pushed the RandellDawson:fix/correct-test-for-auto-fit-challenge branch from 839175d to 545c17b Oct 27, 2019
Copy link
Contributor

ojeytonwilliams left a comment

LGTM 👍

Copy link
Contributor

Manish-Giri left a comment

LGTM

@Manish-Giri Manish-Giri merged commit 5ae8470 into freeCodeCamp:master Nov 8, 2019
2 checks passed
2 checks passed
Gitpod Open an online workspace in Gitpod
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RandellDawson RandellDawson deleted the RandellDawson:fix/correct-test-for-auto-fit-challenge branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.